Remove unrelated labels from example node-local-dns yaml

[Weil0ng]

Just realized there were some accidental GKE-specific labels present in the example node-local-dns yaml. Removing them.

The two removed labels are only used by GKE's addon manager, hence it won't impact other use cases like one in the gsg. They were left there by mistake in the first place.

Signed-off-by: Weilong Cui cuiwl@google.com

[joestringer]

Seems fine to me at a glance, I presume you found this while testing & the new version of these YAMLs still passes the node-local DNS GSG?

Fine by me, but I would tend to defer to k8s folks who have a better understanding of the implications of these labels.

[aditighag]

I suppose the changes are fine since the LRP guide isn't applicable for GKE clusters? IIRC, you need to enable node-local-dns as an add-on on GKE, right?

addonmanager.kubernetes.io/mode: Reconcile

If I remove this annotation, would I be able to deploy node-local-dns after the fact?

From a cursory search, it seems like both the annotations are related to add-on managers. It doesn't hurt to add a note in the commit/PR description about why we can safely remove these annotations.

[Weil0ng]

It doesn't hurt to add a note in the commit/PR description about why we can safely remove these annotations.

Added a bit more explanation in the PR description :)

[Weil0ng]

Do we need to run CI against this PR?

[aditighag]

IIRC, you need to enable node-local-dns as an add-on on GKE, right?

Can you add a note about this in the gsg, or has this requirement changed in recent times?

Do we need to run CI against this PR?

I think we can skip running CI.

[Weil0ng]

IIRC, you need to enable node-local-dns as an add-on on GKE, right?

Can you add a note about this in the gsg, or has this requirement changed in recent times?

I'm not sure LRP gsg is the right place to document this though? This is only if you want GKE supported node-local-dns deployment and it does not affect the workflow described in the gsg, aka deploying upstream node-local-dns + Cilium.