Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Go to 1.16.9 #17566

Merged
merged 1 commit into from
Oct 13, 2021
Merged

Update Go to 1.16.9 #17566

merged 1 commit into from
Oct 13, 2021

Conversation

tklauser
Copy link
Member

No description provided.

@tklauser tklauser added kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact. backport/1.10 labels Oct 11, 2021
@tklauser tklauser requested review from a team as code owners October 11, 2021 10:04
@tklauser tklauser temporarily deployed to release-base-images October 11, 2021 10:04 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 11, 2021 10:04 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 11, 2021 10:53 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 11, 2021 10:53 Inactive
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
Copy link
Member Author

tklauser commented Oct 11, 2021

/test-backport-1.10

Job 'Cilium-PR-Runtime-4.9' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

RuntimePrivilegedUnitTests Run Tests

Failure Output

FAIL: Failed to run privileged unit tests

If it is a flake, comment /mlh new-flake Cilium-PR-Runtime-4.9 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.16-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

[empty]

Failure Output


If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.16-net-next so I can create a new GitHub issue to track it.

@tklauser
Copy link
Member Author

tklauser commented Oct 11, 2021

ci-l4lb-1.10

wasn't started automatically for some reason

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. This will render #17563 unnecessary, so I will close that PR.

@tklauser
Copy link
Member Author

/test-runtime-4.9

@tklauser
Copy link
Member Author

/test-1.16-netnext

@joestringer
Copy link
Member

joestringer commented Oct 13, 2021

Hit #17401 on net-next

Also hit the K8sEgressGateway tests failing (two of them, with and without endpoint routes). I haven't seen that before:

What's weird about this is that I can't find such tests in the v1.10 branch. 🤔

EDIT: Correction, it was introduced in the most recent commit. Looks like it's already broken for the v1.10 branch 😢 f5a5149

@joestringer
Copy link
Member

Since the egress gateway tests are new, it's likely that they're either broken on this branch or newly flaky. I've filed #17604 to follow up, but will ignore it for now to get the release out.

@joestringer joestringer merged commit 27553fb into v1.10 Oct 13, 2021
@joestringer joestringer deleted the pr/v1.10-update-go-1.16.9 branch October 13, 2021 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/backports This PR provides functionality previously merged into master. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants