k8sT/Egress: fixes

[kkourt]

This PR includes fixes for the k8sT/egress test. It is a followup PR for #17517 (review).

Updates:

1. @pchaigno noticed that the context helper was wrong, which lead to some kubectl commands being called with an empty namespace. In addition to that, I've added another commit to print the egress and nat tables in case of a failure. This is meant to help identify potential issues as reported in CI: v1.10: K8sEgressGatewayTest tunnel disabled with endpoint routes enabled Checks egress policy and basic connectivity both work: curl failed to connect with exit code 28 #17604.

2. turns out that starting cilium at the begging was actually needed. fix the patch to just add a comment.

3. removed = from tests names, to avoid:

   The Namespace "202110141537k8segressgatewaytesttunnel=disabledwithendpointrout" is invalid: metadata.name: Invalid value: "202110141537k8segressgatewaytesttunnel=disabledwithendpointrout": a DNS-1123 label must consist of lower case alphanumeric characters or '-', and must start and end with an alphanumeric character (e.g. 'my-name', or '123-abc', regex used for validation is 'a-z0-9?')

4. agent bailed out with:

   2021-10-14T20:49:33.226452400Z level=fatal msg="auto-direct-node-routes cannot be used with tunneling. Packets must be routed through the tunnel device." subsys=daemon

   adjusted configuration accordingly

[pchaigno]

Changes from original PR look good to me. The error you had previously looked unrelated to that particular test so probably an issue in your local setup. 🤞 it'll pass on the first try after the rebase.

[kkourt]

/test

[kkourt]

/test

[kkourt]

/test-gke

edit: GKE was failing with, which should be fixed.

15:51:12 Failed to compile test:
15:51:12
15:51:12 # github.com/cilium/cilium/pkg/rate
15:51:12 ../pkg/rate/api_limiter.go:888:13: undefined: math.MaxInt
15:51:12 note: module requires Go 1.17
15:51:12
15:51:12 Ginkgo ran 1 suite in 20.196444393s
15:51:12 Test Suite Failed

[kkourt]

/test-1.21-4.9

edit: after investigation, failure (was on policies) seemed unrelated, so redoing test.

[kkourt]

/test

[kkourt]

/test-only --focus="K8sEgress"

[kkourt]

/test-only --focus="K8sEgress.*"

[kkourt]

/test

[kkourt]

/test-only --focus=".K8sEgressGateway."

[pchaigno]

/test-only --focus=".K8sEgressGateway."

I think our script for test-only expect K8s to be the first thing in the focus string. Did the previous command not work as expected?

[kkourt]

/test-only --focus=".K8sEgressGateway."

I think our script for test-only expect K8s to be the first thing in the focus string. Did the previous command not work as expected?

The K8sEgressGateway test was skipped AFAICT.

[pchaigno]

The K8sEgressGateway test was skipped AFAICT.

Ah, right. That's because you need to pass the appropriate --kernel_version argument.

[kkourt]

/test

[kkourt]

Tests are green. Will open for reviews, and will try to reproduce #17604 using a focus test.

[kkourt]

/test-only --focus=".K8sEgressGateway." --kernel-version="net-next"

[pchaigno]

LGTM! One nit below but not worth addressing IMO unless there are other comments.

[kkourt]

/test-only --focus=".K8sEgressGateway." --kernel_version="net-next"

It's kernel_version, not kernel-version.

[nbusseneau]

👍🏻

[nbusseneau]

I think we need to backport this to 1.10, correct?
NVM I missed the label was there already.

[kkourt]

The last attempt to run the focus test, also does not seem to work:

https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/321/console:

16:00:40  The machine with the name 'k8s1-' was not found configured for
16:00:40  this Vagrant environment.
[Pipeline] }
[Pipeline] // dir
[Pipeline] }
16:00:40  ERROR: script returned exit code 1
16:00:40  Retrying

In any case, I'll mark this as ready-to-merge. (There is an AKS failure, but the code here only modifies the Egress gateway test). Hopefully, 7e14347 will provide more info if we hit #17604 again.

[pchaigno]

The last attempt to run the focus test, also does not seem to work:

https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/321/console:

Weirdly enough, that build was trigered by @nbusseneau's comment 🤔 (CTRL+F for get-gh-comment-info.py: error).

@kkourt Your build is at https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/320/console and failed because of the .* before K8sEgress in your focus string, as said here.

[pchaigno]

That one should work:
/test-only --focus="K8sEgressGateway" --kernel_version="net-next"
Started at https://jenkins.cilium.io/job/Cilium-PR-Tests-Kernel-Focus/322/.