New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
.github: Fix codeQL workflow skip logic #17587
Conversation
I've opened this PR from my own tree, and it is demonstrating the current (old) behaviour where the "Deduce required tests..." logic runs, but the "analyze" step does not run: https://github.com/cilium/cilium/actions/runs/1335318459 I presume that if we merge this, then it will re-enable the "analyze" steps when any Go code changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:yep:
FYI: the workflow uses The reason it did not run the analyze step for the current PR is simply because it does not have changes to any files matching these filters. If you want to try it out, perhaps made a bogus change in any |
Hit #16938 in ConformanceKind test run: https://github.com/cilium/cilium/pull/17587/checks?check_run_id=3876794296 |
Commit 09136ff4f2f1e40c1b63c326520d7cbf271670d0 does not contain "Signed-off-by". Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin |
Between commits 3ceb742 (".github: Skip unnecessary docs test") and b08f700 ("workflows: Skip jobs instead of workflows"), we attempted to add (and fix) logic to skip workflows when the workflow only checks certain types of code. However, this inadvertently disabled the CodeQL workflows. Fix it by adjusting the wildcard logic to properly match any files that end with *.go. Suggested-by: Nicolas Busseneau <nicolas@isovalent.com> Signed-off-by: Joe Stringer <joe@cilium.io>
09136ff
to
3d5a53b
Compare
Between commits 3ceb742 (".github: Skip unnecessary docs test") and
b08f700 ("workflows: Skip jobs instead of workflows"), we attempted
to add (and fix) logic to skip workflows when the workflow only checks
certain types of code. However, this inadvertently disabled the CodeQL
workflows. Fix it by adjusting the wildcard logic.
Suggested-by: Nicolas Busseneau nicolas@isovalent.com