test: Delete hubble-ca-secret when cleaning up #17591
Conversation
jrajahalme
added
kind/bug/CI
|
/test Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
|
@jrajahalme I assume we can close #17525? |
I had forgotten about that. It has more reviews and still does not need to be rebased, so I'll close this one instead. |
|
Oops, there are a number of CI flakes on #17525, so I'll reopen this and close that as some of them might have been resolved in the meanwhile. |
|
/test Job 'Cilium-PR-K8s-1.20-kernel-4.19' has 2 failures but they might be new flakes since it also hit 1 known flakes: #17270 (94.10) |
test/helpers/kubectl.go
Outdated
| @@ -2517,6 +2517,9 @@ func (kub *Kubectl) CiliumInstall(filename string, options map[string]string) er | |||
| return res.GetErr("Unable to delete existing cilium YAML") | |||
| } | |||
|
|
|||
| // Remove any dangling resources not yet deleted | |||
| kub.CleanupCiliumComponents() | |||
|
|
|||
There was a problem hiding this comment.
Adding this here was a mistake.
CleanupCiliumComponents removes all the cilium related components from the cluster, including CRDs.
This means that CiliumNode resources get deleted, too. This causes any new Cilium nodes to get
reassigned IP allocation pools, which may be different than before. This then causes all endpoints
to fail restore and get in a bad shape. This means that all Cilium-managed pods must also be deleted
when this is called!
Remove hubble-ca-secret when cleaning up Cilium components. This may help avoid test fails installing Cilium with this error message: Error: rendered manifests contain a resource that already exists. Unable to continue with install: existing resource conflict: kind: Secret, namespace: kube-system, name: hubble-ca-secret Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
test-delete-hubble-ca-secret
branch
from
63714c2
to
e80a607
Compare
|
/test |
Remove hubble-ca-secret when cleaning up Cilium components. This may help
avoid test fails installing Cilium with this error message:
Error: rendered manifests contain a resource that already
exists. Unable to continue with install: existing resource conflict:
kind: Secret, namespace: kube-system, name: hubble-ca-secret
Signed-off-by: Jarno Rajahalme jarno@isovalent.com