Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Fix reset of CB_PROXY_MAGIC #17592

Merged

Conversation

jrajahalme
Copy link
Member

ctx_store_meta() takes the value as the last parameter. So instead of

	ctx_store_meta(ctx, 0, CB_PROXY_MAGIC);

it should be:

	ctx_store_meta(ctx, CB_PROXY_MAGIC, 0);

In this instance this does not make functional difference as
CB_PROXY_MAGIC is also 0.

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

ctx_store_meta() takes the value as the last parameter. So instead of

		ctx_store_meta(ctx, 0, CB_PROXY_MAGIC);

it should be:

		ctx_store_meta(ctx, CB_PROXY_MAGIC, 0);

In this instance this does not make functional difference as
CB_PROXY_MAGIC is also 0.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added kind/enhancement This would improve or streamline existing functionality. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. labels Oct 13, 2021
@jrajahalme jrajahalme requested review from a team and jrfastab October 13, 2021 13:24
@jrajahalme jrajahalme mentioned this pull request Oct 13, 2021
9 tasks
@joestringer joestringer merged commit c3006a9 into cilium:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement This would improve or streamline existing functionality. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants