Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix label shown as Unknown App in hubble ui for http-sw-app example #17597

Merged
merged 1 commit into from
Oct 20, 2021
Merged

Fix label shown as Unknown App in hubble ui for http-sw-app example #17597

merged 1 commit into from
Oct 20, 2021

Conversation

hemslo
Copy link
Contributor

@hemslo hemslo commented Oct 13, 2021

Fix label shown as Unknown App due to missing labels following instructions at https://docs.cilium.io/en/stable/gettingstarted/hubble/

@hemslo
Fix label shown as Unknown App in hubble ui for http-sw-app example
141c650 
Signed-off-by: Hemslo Wang <hemslo.wang@gmail.com>
@hemslo hemslo requested review from a team and nathanjsweet October 13, 2021 14:04
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 13, 2021
gandro
gandro approved these changes Oct 13, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thank you!

@gandro gandro added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Oct 13, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 13, 2021
nathanjsweet
nathanjsweet approved these changes Oct 19, 2021
View reviewed changes
Copy link
Member

@nathanjsweet nathanjsweet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May the force be with you. ✋

@nathanjsweet nathanjsweet added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 19, 2021
@joamaki joamaki merged commit d135f00 into cilium:master Oct 20, 2021
@hemslo hemslo deleted the fix-example-label branch October 31, 2021 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@nathanjsweet nathanjsweet nathanjsweet approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@hemslo @gandro @nathanjsweet @joamaki