bpf/Makefile: Default to KERNEL=netnext
#17600
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
ti-mo
approved these changes
Oct 14, 2021
The Makefile in bpf/ is used to compile-test our BPF programs but also to compile the kernel-specific object files we use for complexity tests. It takes a KERNEL environment variable to generate BPF programs with the appropriate features enabled. That is, it tries to maximize the program size for each kernel. KERNEL currently defaults to v4.9. On bpf-next, Cilium's BPF programs are sometimes used to validate verifier patches, to measure the performance impact or verify correctness. Since Cilium has some of the largest open source BPF programs, this is a quick way to avoid regressions. Folks using our Makefile for that purpose are unlikely to know about the KERNEL environment variable and will use its default value. To reduce the likelyhood of regressions, we can switch the default KERNEL value to netnext. That will generate BPF programs with all possible options on the latest kernels, which more closely match what bpf-next folks are looking for when testing their patches. Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
bpf-make-defaults-netnext-kernel
branch
from
5e356d1
to
a0d8a7e
Compare
|
As per #17601, I think we can skip the review request on cilium/build here. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Makefile in
bpf/is used to compile-test our BPF programs but also to compile the kernel-specific object files we use for complexity tests. It takes a KERNEL environment variable to generate BPF programs with the appropriate features enabled. That is, it tries to maximize the program size for each kernel. KERNEL currently defaults to v4.9.On bpf-next, Cilium's BPF programs are sometimes used to validate verifier patches, to measure the performance impact or verify
correctness. Since Cilium has some of the largest open source BPF programs, this is a quick way to avoid regressions.
Folks using our Makefile for that purpose are unlikely to know about the KERNEL environment variable and will use its default value. To reduce the likelihood of regressions, we can switch the default KERNEL value to netnext. That will generate BPF programs with all possible options on the latest kernels, which more closely match what bpf-next folks are looking for when testing their patches.