Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

treewide: Use formatted logrus logs when possible #17611

Merged
merged 1 commit into from Oct 18, 2021

Conversation

pchaigno
Copy link
Member

Quick follow up to #16917 (review).

@pchaigno pchaigno added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Oct 14, 2021
@pchaigno pchaigno requested a review from a team October 14, 2021 14:20
@pchaigno pchaigno requested a review from a team as a code owner October 14, 2021 14:20
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat, thanks! I think we could add BPFMapName in a few places, see comments.

pkg/bpf/bpffs_migrate.go Outdated Show resolved Hide resolved
pkg/bpf/bpffs_migrate.go Outdated Show resolved Hide resolved
Signed-off-by: Paul Chaignon <paul@cilium.io>
Copy link
Contributor

@ti-mo ti-mo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@pchaigno
Copy link
Member Author

pchaigno commented Oct 15, 2021

Changes in this pull request are minor and not specifically covered by end-to-end tests. Several tests checked that the code compiles already. Reviews are in. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 15, 2021
@joamaki joamaki merged commit 6cb7c1b into cilium:master Oct 18, 2021
@pchaigno pchaigno deleted the logs-use-logfields branch October 18, 2021 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants