Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: remove libelf dependency and unused nobpf.h #17612

Merged
merged 1 commit into from Oct 19, 2021

Conversation

ti-mo
Copy link
Contributor

@ti-mo ti-mo commented Oct 14, 2021

As flagged by @tklauser in #16917 (comment),
these headers are no longer used, and we no longer need to link against libelf.

bpf: remove libelf dependency and unused nobpf.h

As flagged by @tklauser in cilium#16917 (comment),
these headers are no longer used, and we no longer need to link against libelf.

Signed-off-by: Timo Beckers <timo@isovalent.com>
@ti-mo ti-mo requested a review from a team October 14, 2021 16:17
@ti-mo ti-mo requested review from a team as code owners October 14, 2021 16:17
@ti-mo ti-mo requested a review from joamaki October 14, 2021 16:17
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 14, 2021
@ti-mo ti-mo requested a review from twpayne October 14, 2021 16:17
@ti-mo ti-mo requested a review from jibi October 14, 2021 16:17
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Oct 14, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 14, 2021
Copy link
Contributor

@joamaki joamaki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-4,619 :feelsgood:

@ti-mo
Copy link
Contributor Author

ti-mo commented Oct 15, 2021

/test

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDatapathConfig Host firewall With native routing

Failure Output

FAIL: Kubernetes DNS did not become ready in time

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

Job 'Cilium-PR-Runtime-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

RuntimeLB With Containers validates service recovery on restart

Failure Output

FAIL: Found 1 Cilium logs matching list of errors that must be investigated:

If it is a flake, comment /mlh new-flake Cilium-PR-Runtime-net-next so I can create a new GitHub issue to track it.

@ti-mo
Copy link
Contributor Author

ti-mo commented Oct 18, 2021

/mlh new-flake Cilium-PR-K8s-GKE

👍 created #17628

@ti-mo
Copy link
Contributor Author

ti-mo commented Oct 18, 2021

/mlh new-flake Cilium-PR-Runtime-net-next

👍 created #17629

@ti-mo
Copy link
Contributor Author

ti-mo commented Oct 18, 2021

Hitting unrelated flakes, reviews are in, marking ready.

@ti-mo ti-mo added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 18, 2021
@joamaki joamaki merged commit c67cf7e into cilium:master Oct 19, 2021
@ti-mo ti-mo deleted the pr/tb/no-libelf-nobpf branch October 19, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants