Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pkg: rename egresspolicy package to egressgateway #17630

Merged
merged 1 commit into from Oct 22, 2021
Merged

pkg: rename egresspolicy package to egressgateway #17630

merged 1 commit into from Oct 22, 2021

Conversation

jibi
Copy link
Member

@jibi jibi commented Oct 18, 2021

This commit does not introduce any functional change, it just renames
the package to make it explicit it relates to the egress gateway
feature.

Fixes: #17389

@jibi
pkg: rename egresspolicy package to egressgateway
d47031f 
This commit does not introduce any functional change, it just renames
the package to make it explicit it relates to the egress gateway
feature.

Fixes: #17389
Signed-off-by: Gilberto Bertin <gilberto@isovalent.com>
@jibi jibi added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.10 feature/egress-gateway Impacts the egress IP gateway feature. labels Oct 18, 2021
@jibi jibi requested review from brb and a team October 18, 2021 12:42
@jibi jibi requested a review from a team as a code owner October 18, 2021 12:42
@jibi jibi requested review from a team and ldelossa October 18, 2021 12:42
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Oct 18, 2021
@jibi jibi added the kind/cleanup This includes no functional changes. label Oct 18, 2021
brb
brb approved these changes Oct 18, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jibi
Copy link
Member Author

jibi commented Oct 20, 2021

test-gke

@jibi jibi added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 22, 2021
@kkourt kkourt merged commit 9a9e471 into master Oct 22, 2021
@kkourt kkourt deleted the pr/jibi/rename-egresspolicy-to-egressgateway branch October 22, 2021 12:42
@nebril nebril mentioned this pull request Oct 28, 2021
Merged
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Oct 28, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Nov 26, 2021
@joestringer joestringer mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

@errordeveloper errordeveloper errordeveloper approved these changes

@christarazi christarazi christarazi approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
feature/egress-gateway Impacts the egress IP gateway feature. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.6
Backport done to v1.10
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

egress gw: Rename pkg/egresspolicy to pkg/egressnatpolicy
8 participants
@jibi @brb @errordeveloper @christarazi @ldelossa @kkourt @nebril @qmonnet