Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: disable AKS testing with encryption enabled #17645

Merged
merged 1 commit into from Oct 20, 2021

Conversation

nbusseneau
Copy link
Member

cilium/cilium-cli#342 is hit almost consistently on AKS when running the second cilium connectivity test with encryption enabled.

We disable AKS testing with encryption enabled until it is fixed.

@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 19, 2021
@nbusseneau nbusseneau requested review from a team as code owners October 19, 2021 15:59
@nbusseneau nbusseneau force-pushed the pr/disable-aks-encryption-testing branch from 3836474 to 67e90d2 Compare October 19, 2021 16:01
@nbusseneau
Copy link
Member Author

nbusseneau commented Oct 19, 2021

Link to workflow run testing the changes: https://github.com/cilium/cilium/actions/runs/1363870248

Copy link
Member

@christarazi christarazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending Paul's suggestion

cilium/cilium-cli#342 is hit almost
consistently on AKS when running the second `cilium connectivity test`
with encryption enabled.

We disable AKS testing with encryption enabled until it is fixed.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau force-pushed the pr/disable-aks-encryption-testing branch 2 times, most recently from 4ea5039 to 3bd50dc Compare October 20, 2021 14:49
@nbusseneau
Copy link
Member Author

Test workflow run is green: https://github.com/cilium/cilium/actions/runs/1363870248
Removing temporary test commit, can be marked as ready to merge once all reviews are in.

Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 20, 2021
@nbusseneau
Copy link
Member Author

@aanm aanm merged commit 727988f into master Oct 20, 2021
@aanm aanm deleted the pr/disable-aks-encryption-testing branch October 20, 2021 23:05
@nbusseneau nbusseneau mentioned this pull request Dec 1, 2021
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants