Minor egress gateway fixups #17663
Merged
Minor egress gateway fixups #17663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
area/CI
This comment has been minimized.
This comment has been minimized.
maintainer-s-little-helper
bot
assigned jibi and nathanjsweet and unassigned nathanjsweet
nathanjsweet
requested changes
Oct 22, 2021
pkg/k8s/apis/cilium.io/client/crds/v2alpha1/ciliumegressnatpolicies.yaml
Show resolved
Hide resolved
jibi
reviewed
Oct 25, 2021
Commit a9374b5 ("Add ebpf map cilium_egress_v4 for egress gateway") added some of the code necessary to check the egress gateway map in the alignchecker, but not all. This commit fixes it. Fixes: a9374b5 ("Add ebpf map cilium_egress_v4 for egress gateway") Signed-off-by: Paul Chaignon <paul@cilium.io>
The CiliumEgressNatPolicy CRD had an incorrect Age description, copy pasted from the CiliumIdentity CRD. Fixes: 141cd63 ("Add custom resource for egress nat gateway policy") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
minor-egress-gateway-fixups
branch
from
858b423
to
9e0cc6c
Compare
|
/test |
jibi
approved these changes
Oct 25, 2021
nathanjsweet
approved these changes
Oct 25, 2021
maintainer-s-little-helper
bot
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was following the egress gateway implementation while implementing the SRv6 support and found a couple mistakes. This pull request fixes them. See commits for details.
I had reviewed the egress gateway pull requests, but it's interesting to see how much more you find once you start coding yourself.