bug/pkg/health: Fix Nil Address Issue in Node Update Mechanism #17667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanjsweet
added
release-note/bug
christarazi
reviewed
Oct 21, 2021
nathanjsweet
force-pushed
the
pr/nathanjsweet/skip-nil-ips-on-health-pkg-node-update
branch
3 times, most recently
from
5d44fe9
to
1bface3
Compare
|
/test |
joestringer
approved these changes
Oct 26, 2021
|
I believe cilium/cilium-cli#572 fixed multi-cluster failing intermittently for CI. All tests are currently passing (including the kernel tests). I'm going to rebase and if the multi-cluster tests pass then I'm marking this PR as ready-to-merge. |
It is possible for a node with a "<nil>" primary address to be "added" to the health pkg cache. When this happens subsequent updates **will not** flush out the bad value and thus it will persist as a valid status for a node until the entire cilium daemon is reset. This fixes the bug by not caching nil values at all. Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
nathanjsweet
force-pushed
the
pr/nathanjsweet/skip-nil-ips-on-health-pkg-node-update
branch
from
1bface3
to
1c9ee7c
Compare
nathanjsweet
added
the
ready-to-merge
nebril
deleted the
pr/nathanjsweet/skip-nil-ips-on-health-pkg-node-update
branch
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.6
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible for a node with a "" primary address to
be "added" to the health pkg cache. When this happens subsequent
updates will not flush out the bad value and thus it will
persist as a valid status for a node until the entire cilium
daemon is reset.
This fixes the bug by not caching nil values at all.
Signed-off-by: Nate Sweet nathanjsweet@pm.me