Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert PR #17145 #17675

Merged
merged 1 commit into from Oct 22, 2021
Merged

Revert PR #17145 #17675

merged 1 commit into from Oct 22, 2021

Conversation

nbusseneau
Copy link
Member

This reverts commits b5c9b55 through 5a2c816.

Rationale: it seems this broke clustermesh functionality, as both external workloads and multicluster testing workflows are consistently failing since merge. The two workflows also did not pass in the original PR, with the same errors.

  • External workloads: standalone Cilium agent is unable to come up while trying to reach clustermesh apiserver.
  • Multicluster: cross-cluster traffic not being able to reach the other cluster during connectivity test.

This reverts commits b5c9b55 through
5a2c816.

Rationale: it seems this broke clustermesh functionality, as both
external workloads and multicluster testing workflows are consistently
failing since merge. The two workflows also did not pass in the original
PR, with the same errors.

- External workloads: standalone Cilium agent is unable to come up while
  trying to reach clustermesh apiserver.
- Multicluster: cross-cluster traffic not being able to reach the other
  cluster during connectivity test.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Oct 22, 2021
@nbusseneau nbusseneau requested review from a team as code owners October 22, 2021 14:56
@nbusseneau nbusseneau requested review from a team and nebril October 22, 2021 14:56
@nbusseneau
Copy link
Member Author

/cc @joestringer original PR author.

@nbusseneau
Copy link
Member Author

nbusseneau commented Oct 22, 2021

/ci-external-workloads

EDIT: Link to workflow run: https://github.com/cilium/cilium/actions/runs/1372702921

@nbusseneau
Copy link
Member Author

nbusseneau commented Oct 22, 2021

/ci-multicluster

EDIT: Link to workflow run: https://github.com/cilium/cilium/actions/runs/1372703320

Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spotting, didn't realize these were causing failures. 👍 🚢

@joestringer joestringer merged commit e057d60 into cilium:master Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants