Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WireGuard status to cilium encrypt. #17684

Merged
merged 1 commit into from Oct 26, 2021
Merged

Add WireGuard status to cilium encrypt. #17684

merged 1 commit into from Oct 26, 2021

Conversation

h3llix
Copy link
Contributor

@h3llix h3llix commented Oct 24, 2021

Fixes: #17274
image

@h3llix h3llix requested a review from a team as a code owner October 24, 2021 23:24
@h3llix h3llix requested a review from ldelossa October 24, 2021 23:24
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 24, 2021
@h3llix h3llix force-pushed the dumpWireGuard branch 2 times, most recently from 5ce7be8 to 196e5f6 Compare October 24, 2021 23:46
@pchaigno pchaigno added the release-note/minor This PR changes functionality that users may find relevant to operating Cilium. label Oct 25, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2021
@pchaigno pchaigno changed the title Add wireguard status to cilium encrypt. Add WireGuard status to cilium encrypt. Oct 25, 2021
gandro
gandro reviewed Oct 25, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks! Three minor nits on the proposed output format

cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
pchaigno
pchaigno reviewed Oct 25, 2021
View reviewed changes
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
@pchaigno pchaigno added the area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. label Oct 25, 2021
ldelossa
ldelossa approved these changes Oct 25, 2021
View reviewed changes
Copy link
Contributor

@ldelossa ldelossa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved contingent on existing feedback being implemented.

gandro
gandro approved these changes Oct 26, 2021
View reviewed changes
Copy link
Member

@gandro gandro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, thanks for taking care of this!

pchaigno
pchaigno reviewed Oct 26, 2021
View reviewed changes
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
cilium/cmd/encrypt_status.go Outdated Show resolved Hide resolved
@h3llix
cli: add wireguard status to cilium encrypt
fe99ca3 
Fixes: cilium#17274
Signed-off-by: Gaurav Genani <h3llix.pvt@gmail.com>
@h3llix
Copy link
Contributor Author

h3llix commented Oct 26, 2021

Thanks @gandro and @pchaigno. One day I'll give PR without any silly nits 😢.

@pchaigno
Copy link
Member

This isn't covered by any end-to-end tests, so marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 26, 2021
@kkourt kkourt merged commit 02012cb into cilium:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gandro gandro gandro approved these changes

@pchaigno pchaigno pchaigno approved these changes

@ldelossa ldelossa ldelossa approved these changes

Assignees
No one assigned
Labels
area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend cilium encrypt to provide information on WireGuard Transparent Encryption.
5 participants
@h3llix @pchaigno @gandro @ldelossa @kkourt