Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI, docs: remove libelf-dev from dependencies #17686

Closed
wants to merge 1 commit into from
Closed

CI, docs: remove libelf-dev from dependencies #17686

wants to merge 1 commit into from

Conversation

tklauser
Copy link
Member

Since commit 4db3166 ("cilium-map-migrate: remove program and all
of its references") cilium-map-migrate has been replaced by a binary
written in Go and we no longer link binaries against libelf as of commit
c67cf7e ("bpf: remove libelf dependency and unused nobpf.h"). Thus,
drop libelf-dev from dependencies in CI and documentations.

@tklauser
CI, docs: remove libelf-dev from dependencies
07e2950 
Since commit 4db3166 ("cilium-map-migrate: remove program and all
of its references") cilium-map-migrate has been replaced by a binary
written in Go and we no longer link binaries against libelf as of commit
c67cf7e ("bpf: remove libelf dependency and unused nobpf.h"). Thus,
drop libelf-dev from dependencies in CI and documentations.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Oct 25, 2021
@tklauser tklauser requested review from a team as code owners October 25, 2021 08:51
@tklauser tklauser requested a review from glibsm October 25, 2021 08:51
@tklauser tklauser temporarily deployed to release-base-images October 25, 2021 08:51 Inactive
@tklauser tklauser temporarily deployed to release-base-images October 25, 2021 08:51 Inactive
@tklauser
Copy link
Member Author

tklauser commented Oct 25, 2021 •
edited

Re-opening from a non-fork branch because the cilium-builder image needs to be updated: #17687

@tklauser tklauser closed this Oct 25, 2021
@tklauser tklauser deleted the libelf-dev-remove branch October 25, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glibsm glibsm Awaiting requested review from glibsm glibsm was automatically assigned from cilium/build

@nbusseneau nbusseneau Awaiting requested review from nbusseneau nbusseneau was automatically assigned from cilium/ci-structure

@aditighag aditighag Awaiting requested review from aditighag aditighag was automatically assigned from cilium/contributing

@qmonnet qmonnet Awaiting requested review from qmonnet qmonnet was automatically assigned from cilium/docs-structure

Assignees

@glibsm glibsm

@nbusseneau nbusseneau

@qmonnet qmonnet

@aditighag aditighag

Labels
area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tklauser @glibsm @nbusseneau @qmonnet @aditighag