Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable CiliumEndpointSlice feature testing on Kuberneres version 1.21 #17698

Merged
merged 1 commit into from Nov 5, 2021
Merged

Enable CiliumEndpointSlice feature testing on Kuberneres version 1.21 #17698

merged 1 commit into from Nov 5, 2021

Conversation

krishgobinath
Copy link
Contributor

Enable CiliumEndpointSlice feature, CI testing only on Kubernetes
version 1.21.

Signed-off-by: Gobinath Krishnamoorthy gobinathk@google.com

@krishgobinath krishgobinath requested a review from a team as a code owner October 25, 2021 18:30
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Oct 25, 2021
@krishgobinath krishgobinath marked this pull request as draft October 25, 2021 18:31
@Weil0ng Weil0ng mentioned this pull request Oct 26, 2021
Merged
4 tasks
@krishgobinath krishgobinath mentioned this pull request Oct 26, 2021
Merged
joestringer
joestringer requested changes Oct 26, 2021
View reviewed changes
test/helpers/utils.go Outdated Show resolved Hide resolved
test/helpers/utils.go Outdated Show resolved Hide resolved
@krishgobinath krishgobinath marked this pull request as ready for review October 26, 2021 18:17
tklauser
tklauser reviewed Oct 29, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We now have coverage for k8s 1.22 in our CI. I think you'll need to rebase the PR branch to latest master though for it to work (/cc @nbusseneau). As Joe pointed out, it'd be nice to enable the test for k8s >= 1.21.

Another small nit, there is a typo in the commit message and PR title: s/Kuberneres/Kubernetes/

test/helpers/utils.go Outdated Show resolved Hide resolved
@krishgobinath
Copy link
Contributor Author

We now have coverage for k8s 1.22 in our CI. I think you'll need to rebase the PR branch to latest master though for it to work (/cc @nbusseneau). As Joe pointed out, it'd be nice to enable the test for k8s >= 1.21.

Another small nit, there is a typo in the commit message and PR title: s/Kuberneres/Kubernetes/

Thanks for pointing updated.

@tklauser tklauser added the release-note/ci This PR makes changes to the CI. label Nov 1, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 1, 2021
joestringer
joestringer reviewed Nov 1, 2021
View reviewed changes
test/helpers/utils.go Outdated Show resolved Hide resolved
Enable CiliumEndpointSlice feature testing on Kubernetes version 1.21
d2d8305 
Enable CiliumEndpointSlice feature, CI testing only on Kubernetes
version greater than or equal to 1.21.

Signed-off-by: Gobinath Krishnamoorthy <gobinathk@google.com>
tklauser
tklauser approved these changes Nov 1, 2021
View reviewed changes
Copy link
Member

@tklauser tklauser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @krishgobinath

@tklauser
Copy link
Member

tklauser commented Nov 1, 2021

/test

@Weil0ng Weil0ng mentioned this pull request Nov 1, 2021
Closed
15 tasks
@pchaigno pchaigno added the area/CI-improvement Topic or proposal to improve the Continuous Integration workflow label Nov 5, 2021
@pchaigno
Copy link
Member

pchaigno commented Nov 5, 2021

Cilium L4LB XDP hit known flake #17799 and multicluster had the usual failures. These CI job are also not affected by the changes in this PR so clearly unrelated. Other than that, reviews are in, so merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 5, 2021
@pchaigno pchaigno merged commit fe26822 into cilium:master Nov 5, 2021
@pchaigno pchaigno mentioned this pull request Dec 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@krishgobinath @tklauser @pchaigno @joestringer