Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Clean up hubble-ui clusterrole #17702

Merged
merged 1 commit into from Oct 26, 2021

Conversation

aditighag
Copy link
Member

@aditighag aditighag commented Oct 26, 2021

Tests can fail with following error if previously
installed cilium resources exist -

Error: rendered manifests contain a resource that already exists. Unable to continue with install: ClusterRole "hubble-ui" in namespace "" exists and cannot be imported into the current release: invalid ownership metadata;

Edit : No need to run any CI test since it's a simple clean-up.

@aditighag aditighag added the release-note/ci This PR makes changes to the CI. label Oct 26, 2021
@aditighag aditighag requested a review from a team as a code owner October 26, 2021 00:54
@maintainer-s-little-helper
Copy link

Commit 2ab1ea0 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 26, 2021
Tests can fail with following error if previously
installed cilium resources exist -

`Error: rendered manifests contain a resource that already exists.
Unable to continue with install: ClusterRole
"hubble-ui" in namespace "" exists and cannot be imported into the
current release: invalid ownership metadata;
`

Signed-off-by: Aditi Ghag <aditi@cilium.io>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Oct 26, 2021
@aditighag aditighag added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 26, 2021
@kkourt kkourt merged commit 3e3df33 into cilium:master Oct 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants