Use cilium-cli sysdump in L4LB tests #17719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tklauser
added
area/CI
tklauser
force-pushed
the
pr/tklauser/l4lb-test-fixes
branch
from
dd3fd3a
to
3616a2c
Compare
Use the `cilium sysdump` command instead of the deprecated cilium-sysdump python script as we already do in other tests. This will also include Hubble flows into the sysdump which the old sysdump tool didn't. Signed-off-by: Tobias Klauser <tobias@cilium.io>
tklauser
force-pushed
the
pr/tklauser/l4lb-test-fixes
branch
from
3616a2c
to
38c73c1
Compare
nebril
approved these changes
Oct 27, 2021
|
ci-l4lb |
@tklauser Need to uncomment the |
tklauser
force-pushed
the
pr/tklauser/l4lb-test-fixes
branch
from
0e667b7
to
ff46975
Compare
|
ci-l4lb |
tklauser
force-pushed
the
pr/tklauser/l4lb-test-fixes
branch
from
ff46975
to
39166e7
Compare
|
ci-l4lb |
|
Successful example run with collected sysdump: https://github.com/cilium/cilium/actions/runs/1390730121 Removing "DO NOT MERGE" commit. |
tklauser
force-pushed
the
pr/tklauser/l4lb-test-fixes
branch
from
39166e7
to
38c73c1
Compare
jibi
approved these changes
Oct 27, 2021
nbusseneau
approved these changes
Oct 27, 2021
tklauser
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the
cilium sysdumpcommand instead of the deprecatedcilium-sysdump python script as we already do in other tests. This will
also include Hubble flows into the sysdump which the old sysdump tool
didn't.
Note: The previous version of this PR contained a change to the l4lb workflow which was based on a false assumption on my side.