Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: Enable debug for l4lb test #17720

Merged
merged 1 commit into from
Oct 27, 2021
Merged

test: Enable debug for l4lb test #17720

merged 1 commit into from
Oct 27, 2021

Conversation

jrajahalme
Copy link
Member

Enable Cilium debug to get debug logs for diagnozing test fails.

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

@jrajahalme
test: Enable debug for l4lb test
13edb1f 
Enable Cilium debug to get debug logs for diagnozing test fails.

Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme added area/CI-improvement Topic or proposal to improve the Continuous Integration workflow release-note/misc This PR makes changes that have no direct user impact. labels Oct 27, 2021
@jrajahalme jrajahalme requested a review from a team as a code owner October 27, 2021 11:38
@jrajahalme jrajahalme requested review from a team, tklauser and borkmann October 27, 2021 11:38
@jrajahalme
Copy link
Member Author

jrajahalme commented Oct 27, 2021 •
edited by maintainer-s-little-helper bot
Loading

/test

Job 'Cilium-PR-K8s-1.20-kernel-4.19' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests NodePort with externalTrafficPolicy=Local

Failure Output

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.20-kernel-4.19 so I can create a new GitHub issue to track it.

@jrajahalme
Copy link
Member Author

@tklauser This was from my fork so the change did not take effect, I'll open another PR from the main repo unless you are OK merging this as-is?

@tklauser
Copy link
Member

@tklauser This was from my fork so the change did not take effect, I'll open another PR from the main repo unless you are OK merging this as-is?

I think the change is simple enough to be merged as-is, unless you think it should be run through CI.

@jrajahalme jrajahalme added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 27, 2021
@jrajahalme
Copy link
Member Author

Labeled ready-to-merge based on @tklauser's review.

@kkourt kkourt merged commit 4495f0b into cilium:master Oct 27, 2021
@jrajahalme jrajahalme mentioned this pull request Oct 27, 2021
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tklauser tklauser tklauser approved these changes

@borkmann borkmann Awaiting requested review from borkmann

Assignees

@borkmann borkmann

Labels
area/CI-improvement Topic or proposal to improve the Continuous Integration workflow ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jrajahalme @tklauser @kkourt @borkmann