Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependabot: re-enable Ginkgo updates #17742

Merged
merged 2 commits into from Nov 2, 2021

Conversation

tklauser
Copy link
Member

Automatic Ginkgo updates were disabled by commit 0c760d8
("dependabot: ignore ginkgo updates") due to it breaking CI at the time.
Ginkgo has since been updated manually to 1.16.4 in commit bc5ce29
("ginkgo: Update to 1.16.4") and this CI breakage seems to be gone, so
re-enable automatic updates by dependabot.

Automatic Ginkgo updates were disabled by commit 0c760d8
("dependabot: ignore ginkgo updates") due to it breaking CI at the time.
Ginkgo has since been updated manually to 1.16.4 in commit bc5ce29
("ginkgo: Update to 1.16.4") and this CI breakage seems to be gone, so
re-enable automatic updates by dependabot.

Suggested-by: Paul Chaignon <paul@cilium.io>
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added the release-note/misc This PR makes changes that have no direct user impact. label Oct 29, 2021
@tklauser tklauser requested a review from a team as a code owner October 29, 2021 07:32
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we update the ginkgo dependency at the same time? Otherwise, I'm guessing dependabot will do it after we merge this.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
Copy link
Member Author

Should we update the ginkgo dependency at the same time? Otherwise, I'm guessing dependabot will do it after we merge this.

Good point. I've added an additional commit to update Ginkgo to 1.16.5.

@tklauser tklauser closed this Oct 29, 2021
@tklauser tklauser reopened this Oct 29, 2021
@pchaigno
Copy link
Member

/test

@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. and removed release-note/misc This PR makes changes that have no direct user impact. labels Oct 29, 2021
@tklauser tklauser removed the request for review from aditighag October 29, 2021 13:28
@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Oct 29, 2021
@nebril nebril merged commit a64fdfa into cilium:master Nov 2, 2021
@tklauser tklauser deleted the dependabot-update-ginkgo branch November 2, 2021 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants