v1.10 backport of "Allowed to set labels to ServiceMonitors"

[canhnt]

• Allow to set labels to ServiceMonitors #17509 -- Allow to set labels to ServiceMonitors (@canhnt)

Once this PR is merged, you can update the PR labels via:

$ for pr in 17509; do contrib/backporting/set-labels.py $pr done 1.10; done

[gandro]

Thanks for the backport! Reviewers, please see the following comment for some context: #17509 (comment)

[nathanjsweet]

/test-backport-1.10

[pchaigno]

The commit description should reference the master commit. See other backported commits on branch v1.10 for examples on the format.

In general, I'd recommend using our backporting scripts as they configure all that automatically: https://docs.cilium.io/en/latest/contributing/release/backports/#creating-the-backports-branch.

[canhnt]

The commit description should reference the master commit. See other backported commits on branch v1.10 for examples on the format.

In general, I'd recommend using our backporting scripts as they configure all that automatically: https://docs.cilium.io/en/latest/contributing/release/backports/#creating-the-backports-branch.

@pchaigno : May I just update commit description following the backport template? Using backport script requires needs-backport/1.0 label for #17509 and backport-pending/1.10 for this PR, that I cannot add labels myself.

[kaworu]

I've updated this PR title, description, and added the backport-pending/1.10 label to #17509. @canhnt please set the commit message to:

Allowed to set labels to ServiceMonitors

[ upstream commit 105e1ab10b560957e1d550ece789ef77ea990c15 ]

Signed-off-by: Canh Ngo <canhnt@gmail.com>

and then re-request a review from @pchaigno.

[canhnt]

I've updated this PR title, description, and added the backport-pending/1.10 label to #17509. @canhnt please set the commit message to:

Allowed to set labels to ServiceMonitors

[ upstream commit fe5628875b730a58886f41c3f4919849649151c2 ]

Signed-off-by: Canh Ngo <canhnt@gmail.com>

and then re-request a review from @pchaigno.

@kaworu : Is commit id fe5628875b730a58886f41c3f4919849649151c2 correct? That is fe56288

It seems the 105e1ab10b560957e1d550ece789ef77ea990c15 refers to the commit in the #17746: 105e1ab

[kaworu]

@canhnt yes 105e1ab is the correct one, sorry for my confusion!

[canhnt]

@canhnt yes 105e1ab is the correct one, sorry for my confusion!

Thank you. I updated commit message as suggested.

[pchaigno]

Thanks @kaworu and @canhnt!

[kaworu]

/test-backport-1.10

[pchaigno]

This change is not covered by end-to-end tests and reviews are in. Marking ready to merge and merging.