Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typo(rename): v4ClusterCIDR -> clusterCIDR #17763

Merged
merged 1 commit into from Nov 4, 2021
Merged

typo(rename): v4ClusterCIDR -> clusterCIDR #17763

merged 1 commit into from Nov 4, 2021

Conversation

cndoit18
Copy link
Contributor

@cndoit18 cndoit18 commented Nov 3, 2021 •
edited by qmonnet

Signed-off-by: cndoit18 cndoit18@outlook.com

Please ensure your pull request adheres to the following guidelines:

  • For first time contributors, read Submitting a pull request
  • All code is covered by unit and/or runtime tests where feasible.
  • All commits contain a well written commit description including a title,
    description and a Fixes: #XXX line if the commit addresses a particular
    GitHub issue.
  • All commits are signed off. See the section Developer’s Certificate of Origin
  • Provide a title or release-note blurb suitable for the release notes.
  • Thanks for contributing!
podcidr: rename a variable, to remove its "v4" prefix in a context where it can refer either to IPv4 or IPv6

@cndoit18 cndoit18 requested review from a team and twpayne November 3, 2021 06:52
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 3, 2021
@cndoit18 cndoit18 changed the title typo(rename): rename: v4ClusterCIDR -> clusterCIDR typo: rename: v4ClusterCIDR -> clusterCIDR Nov 3, 2021
@cndoit18 cndoit18 changed the title typo: rename: v4ClusterCIDR -> clusterCIDR typo(rename): v4ClusterCIDR -> clusterCIDR Nov 3, 2021
@twpayne twpayne added the release-note/misc This PR makes changes that have no direct user impact. label Nov 3, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 3, 2021
twpayne
twpayne approved these changes Nov 3, 2021
View reviewed changes
Copy link
Contributor

@twpayne twpayne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@twpayne twpayne added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 3, 2021
@twpayne
Copy link
Contributor

twpayne commented Nov 3, 2021

As this is a variable rename, we don't need a full CI run. Marking as ready-to-merge.

@maintainer-s-little-helper
Copy link

Commit b948fd99fc5d893edf06dd1e08ff6c0f3e8b2218 does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 4, 2021
@cndoit18 cndoit18 requested review from a team as code owners November 4, 2021 00:16
@cndoit18 cndoit18 requested a review from a team November 4, 2021 00:16
@cndoit18 cndoit18 requested a review from a team as a code owner November 4, 2021 00:16
@cndoit18
style(rename): rename: v4ClusterCIDR -> clusterCIDR
b1db5d4 
Signed-off-by: cndoit18 <cndoit18@outlook.com>
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 4, 2021
@gandro gandro removed request for a team, nebril and aanm November 4, 2021 09:55
@gandro gandro unassigned nebril and aanm Nov 4, 2021
@nathanjsweet nathanjsweet merged commit de768cd into cilium:master Nov 4, 2021
@cndoit18 cndoit18 deleted the typo-podcidr branch November 5, 2021 01:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twpayne twpayne twpayne approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees
No one assigned
Labels
ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cndoit18 @twpayne @qmonnet @nathanjsweet @nebril @aanm