Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

operator: remove deprecated Azure cloud name flag #17765

Merged
merged 1 commit into from
Nov 4, 2021
Merged

operator: remove deprecated Azure cloud name flag #17765

merged 1 commit into from
Nov 4, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 3, 2021

Commit b29389d ("Auto-detect Azure cloud name via IMDS") marked the
flag as deprecated in 1.10 and to be removed in 1.11.

@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. area/azure Impacts Azure based IPAM. labels Nov 3, 2021
@tklauser tklauser requested review from a team as code owners November 3, 2021 10:37
@tklauser tklauser requested a review from a team November 3, 2021 10:37
@tklauser tklauser requested a review from a team as a code owner November 3, 2021 10:37
@tklauser tklauser requested a review from qmonnet November 3, 2021 10:37
@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2021

ci-aks

qmonnet
qmonnet approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good thank you!
Two minor nits below, but they're non-blocking.

Documentation/operations/upgrade.rst Outdated Show resolved Hide resolved
pkg/ipam/allocator/azure/azure.go Outdated Show resolved Hide resolved
@tklauser
operator: remove deprecated Azure cloud name flag
1b88b2e 
Commit b29389d ("Auto-detect Azure cloud name via IMDS") marked the
flag as deprecated in 1.10 and to be removed in 1.11.

Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2021

ci-aks

ungureanuvladvictor
ungureanuvladvictor approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@ungureanuvladvictor ungureanuvladvictor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this @tklauser !

@tklauser
Copy link
Member Author

tklauser commented Nov 3, 2021

All reviews are in and the AKS test passed, no need to run full CI. Marking as ready to merge.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 3, 2021
@nathanjsweet nathanjsweet merged commit 858fca7 into cilium:master Nov 4, 2021
@tklauser tklauser deleted the operator-deprecated-flags branch November 4, 2021 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qmonnet qmonnet qmonnet approved these changes

@ungureanuvladvictor ungureanuvladvictor ungureanuvladvictor approved these changes

Assignees
No one assigned
Labels
area/azure Impacts Azure based IPAM. kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tklauser @ungureanuvladvictor @qmonnet @nathanjsweet