test: Do not require netpols in 'waitNextPolicyRevisions()' #17769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrajahalme
added
area/CI
|
/test |
christarazi
reviewed
Nov 3, 2021
tklauser
reviewed
Nov 3, 2021
pchaigno
approved these changes
Nov 3, 2021
'waitNextPolicyRevisions()' currently returns 'true' when no k8s network policies are applied, bypassing the Cilium agent policy revision wait in this case. As our tests typically (never?) have no NPs applied, we have not actually waited for CNP or CCNP changes to take place in all Cilium PODs before proceeding with the tests. This may have caused CI flakes. Fix this by removing the code that checks for the presence of NPs. Reported-by: Paul Chaignon <paul@cilium.io> Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
jrajahalme
force-pushed
the
test-fix-policy-wait
branch
from
6fad992
to
35851d1
Compare
|
/test Job 'Cilium-PR-K8s-1.20-kernel-5.4' failed and has not been observed before, so may be related to your PR: Click to show.Test NameFailure OutputIf it is a flake, comment |
tklauser
approved these changes
Nov 4, 2021
|
Reviews are in. All affected test suites passed except for k8s-1.20-kernel-5.4 which failed with known flake #16852. Marking ready to merge and merging. |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.8
in 1.8.13
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.12
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'waitNextPolicyRevisions()' currently returns 'true' when no k8s
network policies are applied, bypassing the Cilium agent policy
revision wait in this case. As our tests typically (never?) have no
NPs applied, we have not actually waited for CNP or CCNP changes to
take place in all Cilium PODs before proceeding with the tests. This
may have caused CI flakes.
Fix this by removing the code that checks for the presence of NPs.
Reported-by: Paul Chaignon paul@cilium.io
Signed-off-by: Jarno Rajahalme jarno@isovalent.com