operator: Hidden flags for egress gateway and LRPs #17772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some of the CRD registrations (e.g., CENP and CLRP) are conditioned on feature flags. In some cases, that registration happens in the operator, in which case it needs to be possible to enable the features there. Reproduced and tested in the development VM where the operator is in charge of registering the CRDs. Without this patch, the CRDs are never created and the agent waits indefinitely when e.g. the egress gateway is enabled. With this patch, the egress gateway can be enabled in the operator via a flag to trigger the registration of the CRD. Suggested-by: Joe Stringer <joe@cilium.io> Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
added
kind/bug
|
/test |
aanm
approved these changes
Nov 3, 2021
|
All team review requests are covered and tests are passing. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of the CRD registrations (e.g., CENP and CLRP) are conditioned on feature flags. In some cases, that registration happens in the operator, in which case it needs to be possible to enable the features there.
Reproduced and tested in the development VM where the operator is in charge of registering the CRDs. Without this patch, the CRDs are never created and the agent waits indefinitely when e.g. the egress gateway is enabled. With this patch, the egress gateway can be enabled in the operator via a flag to trigger the registration of the CRD.