Prometheus lint errors in operator metrics #17789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maintainer-s-little-helper
bot
added
the
dont-merge/needs-release-note-label
joestringer
reviewed
Nov 5, 2021
There was a problem hiding this comment.
I think that in general we should conform to promtool recommendations like this, so I'm fine with this from that perspective. If these are already in released versions of Cilium then we should also mention that the metrics are being renamed in the Upgrade guide. There should be examples like that already in the docs.
pchaigno
added
area/metrics
maintainer-s-little-helper
bot
removed
dont-merge/needs-release-note-label
errordeveloper
approved these changes
Nov 8, 2021
|
@krishgobinath could you add the information mentioned by Joe here in the upgrade guide? thank you |
aanm
added
needs-backport/1.11
release-note/bug
krishgobinath
force-pushed
the
promtoolmetrics
branch
from
4d9d320
to
d0e8b66
Compare
joestringer
requested changes
Nov 23, 2021
qmonnet
approved these changes
Nov 23, 2021
krishgobinath
force-pushed
the
promtoolmetrics
branch
from
d0e8b66
to
fc83d31
Compare
joestringer
approved these changes
Nov 23, 2021
joestringer
requested changes
Nov 23, 2021
Promtool identified following lint errors when running against operator metrics 1) cilium_operator_identity_gc_entries_total non-counter metrics should not have "_total" suffix 2) cilium_operator_identity_gc_runs_total non-counter metrics should not have "_total" suffix Add relevant changes in upgrade documentation for 1.10 and 1.11 Fixing both the non-counter metrics. Signed-off-by: Gobinath Krishnamoorthy <gobinathk@google.com>
krishgobinath
force-pushed
the
promtoolmetrics
branch
from
fc83d31
to
98487cc
Compare
joestringer
approved these changes
Nov 29, 2021
nathanjsweet
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Promtool identified following lint errors when running against operator metrics
Fixing both the non-counter metrics.
Signed-off-by: Gobinath Krishnamoorthy gobinathk@google.com