Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: Increase reporting threshold for new flakes #17812

Merged

Conversation

pchaigno
Copy link
Member

@pchaigno pchaigno commented Nov 8, 2021

MLH assumes a flake is a new one if the similarity to existing flakes is below 75%. This threshold is a bit low for flakes affecting the same test but failing with a different error message. We can adjust to 85% and see.

Related: #17270.

MLH assumes a flake is a new one if the similarity to existing flakes is
below 75%. This threshold is a bit low for flakes affecting the same
test but failing with a different error message. We can adjust to 85%
and see.

Related: cilium#17270.
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact. labels Nov 8, 2021
@pchaigno pchaigno requested a review from aanm November 8, 2021 09:47
@pchaigno pchaigno requested a review from a team as a code owner November 8, 2021 09:47
@aanm
Copy link
Member

aanm commented Nov 8, 2021

@pchaigno I think a similar patch needs to be done on all branches.

@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Nov 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.8.14 Nov 8, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.9.12 Nov 8, 2021
@pchaigno pchaigno merged commit 693163e into cilium:master Nov 8, 2021
@pchaigno pchaigno deleted the increase-flake-reporting-threshold branch November 8, 2021 16:13
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.9 in 1.9.12 Nov 9, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.10 in 1.10.6 Nov 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.8 in 1.8.14 Nov 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.9 to Backport done to v1.9 in 1.9.12 Nov 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.8 to Backport done to v1.8 in 1.8.14 Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.6
Backport done to v1.10
1.8.14
Backport done to v1.8
1.9.12
Backport done to v1.9
Development

Successfully merging this pull request may close these issues.

None yet

5 participants