Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: use ctx_redirect{,_peer}() instead of redirect{,_peer}() #17814

Merged
merged 1 commit into from Nov 9, 2021
Merged

bpf: use ctx_redirect{,_peer}() instead of redirect{,_peer}() #17814

merged 1 commit into from Nov 9, 2021

Conversation

tklauser
Copy link
Member

@tklauser tklauser commented Nov 8, 2021

Use the ctx-specific helpers. This also allows to drop the __ctx_is
check in redirect_ep().

Fixes #17682

@tklauser tklauser added sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. release-note/misc This PR makes changes that have no direct user impact. kind/tech-debt Technical debt labels Nov 8, 2021
@tklauser tklauser requested review from brb and a team November 8, 2021 11:55
@tklauser
bpf: use ctx_redirect{,peer}() instead of redirect{._peer}()
1135bf8 
Use the ctx-specific helpers. This also allows to drop the __ctx_is
check in redirect_ep().

Signed-off-by: Tobias Klauser <tobias@cilium.io>
brb
brb approved these changes Nov 8, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tklauser
Copy link
Member Author

tklauser commented Nov 9, 2021

/test

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 9, 2021
@tklauser tklauser changed the title bpf: use ctx_redirect{,peer}() instead of redirect{._peer}() bpf: use ctx_redirect{,_peer}() instead of redirect{,_peer}() Nov 9, 2021
@pchaigno pchaigno merged commit 4f3e39e into cilium:master Nov 9, 2021
@tklauser tklauser deleted the bpf-ctx-redirect branch November 9, 2021 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
kind/tech-debt Technical debt ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

datapath: Use ctx_redirect{,_peer}() instead of redirect{,_peer}().
3 participants
@tklauser @brb @pchaigno