helm: Disable BPF masquerading in v1.10+ #17824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pchaigno
added
release-note/minor
pchaigno
force-pushed
the
disable-bpf-masquerade-by-default
branch
2 times, most recently
from
c656d01
to
b70e353
Compare
|
/test |
kaworu
approved these changes
Nov 12, 2021
aanm
requested changes
Nov 16, 2021
In Cilium v1.10, we disabled kube-proxy-replacement by default but left BPF masquerading enabled. Since the latter requires the former, the default installation results in a warning. This commit fixes the warning by disabling BPF masquerading as well on new v1.10+ deployments. Fixes: 5412142 ("install: Disable kube-proxy-replacement by default") Signed-off-by: Paul Chaignon <paul@cilium.io>
pchaigno
force-pushed
the
disable-bpf-masquerade-by-default
branch
from
b70e353
to
3ef072c
Compare
|
The new push only adds a comment. The tests were previously all green with the exception of k8s-1.21-kernel-4.19 which was failing with known flake #17353. Marking ready to merge. |
pchaigno
added
the
ready-to-merge
aanm
approved these changes
Nov 16, 2021
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Needs backport from master
to Backport pending to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
maintainer-s-little-helper
bot
moved this from Backport pending to v1.10
to Backport done to v1.10
in 1.10.6
|
@pchaigno FYI 1.10 docs mention |
|
@stevo-f3 Nice catch! Do you want to send a pull request to fix it? We can then backport the fix to all stable branches. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Cilium v1.10, we disabled kube-proxy-replacement by default but left BPF masquerading enabled. Since the latter requires the former, the default installation results in a warning.
This pull request fixes the warning by disabling BPF masquerading as well on new v1.10+ deployments.
Fixes: #15422.