Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: Disable K8s upstream tests that we do not support #17828

Merged

Conversation

nathanjsweet
Copy link
Member

Tests for internalTrafficPolicy=Local and SCTP that were added
in 1.22 should be disabled as we support neither scenario

Signed-off-by: Nate Sweet nathanjsweet@pm.me

Please ensure your pull request adheres to the following guidelines:

Fixes: #17796

@nathanjsweet nathanjsweet added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 9, 2021
@nathanjsweet nathanjsweet requested a review from a team as a code owner November 9, 2021 00:24
test/kubernetes-test.sh Show resolved Hide resolved
Copy link
Member

@pchaigno pchaigno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending Aditi's review.

@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/disable-sctp-and-local-internal-traffic-tests branch from 060d243 to 6e2af22 Compare November 9, 2021 15:03
@pchaigno
Copy link
Member

pchaigno commented Nov 9, 2021

test-upstream-k8s

test/kubernetes-test.sh Outdated Show resolved Hide resolved
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 17, 2021
Tests for internalTrafficPolicy=Local and SCTP that were added
in 1.22 should be disabled as we support neither scenario

Co-authored-by: Nicolas Busseneau <nicolas@isovalent.com>

Signed-off-by: Nate Sweet <nathanjsweet@pm.me>
Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nathanjsweet nathanjsweet force-pushed the pr/nathanjsweet/disable-sctp-and-local-internal-traffic-tests branch from 2f99e1b to 1c9106b Compare November 17, 2021 16:22
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 17, 2021
@cilium cilium deleted a comment from maintainer-s-little-helper bot Nov 17, 2021
@nbusseneau
Copy link
Member

/test-upstream-k8s

Copy link
Member

@nbusseneau nbusseneau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream test passed. This PR does not need to run any additional CI and reviews are in, marking as ready to merge.

@nbusseneau nbusseneau added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 17, 2021
@gandro gandro merged commit 784fe07 into master Nov 18, 2021
@gandro gandro deleted the pr/nathanjsweet/disable-sctp-and-local-internal-traffic-tests branch November 18, 2021 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

k8s-upstream: SCTP tests failing
5 participants