helm: Fix hubble-ui clusterrole guard #17846
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug where the hubble-ui cluster role was created even if Hubble UI was disabled (i.e. `hubble.ui.enabled=false`). The cluster role should only be created if the UI is deployed. Fixes: cc09bde ("feat: allow installing hubble ui as standalone") Signed-off-by: Sebastian Wicki <sebastian@isovalent.com>
gandro
added
release-note/misc
geakstr
approved these changes
Nov 10, 2021
kaworu
approved these changes
Nov 11, 2021
|
Thanks for the fix @gandro! |
sayboras
approved these changes
Nov 11, 2021
|
Marking this as ready to merge, since Hubble UI is not covered by CI. (Travis failed with Docker rate limit) |
gandro
added
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug where the hubble-ui cluster role was created even if
Hubble UI was disabled (i.e.
hubble.ui.enabled=false). The clusterrole should only be created if the UI is deployed.
This guard used to exist, but got accidentally removed when we added
support for Hubble UI standalone installation mode.
Fixes: cc09bde ("feat: allow installing hubble ui as standalone")
Signed-off-by: Sebastian Wicki sebastian@isovalent.com