Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpf: remove accidentally committed cilium-map-migrate binary #17860

Merged
merged 1 commit into from Nov 15, 2021
Merged

bpf: remove accidentally committed cilium-map-migrate binary #17860

merged 1 commit into from Nov 15, 2021

Conversation

tklauser
Copy link
Member

Commit 25b985c ("vendor: metallb bump") accidentally added the
cilium-map-migrate binary to the tree, remove it.

Fixes: 25b985c ("vendor: metallb bump")

@tklauser
bpf: remove accidentally committed cilium-map-migrate binary
305cd03 
Commit 25b985c ("vendor: metallb bump") accidentally added the
cilium-map-migrate binary to the tree, remove it.

Fixes: 25b985c ("vendor: metallb bump")
Signed-off-by: Tobias Klauser <tobias@cilium.io>
@tklauser tklauser added kind/cleanup This includes no functional changes. release-note/misc This PR makes changes that have no direct user impact. labels Nov 12, 2021
@tklauser tklauser requested review from a team and brb November 12, 2021 11:24
brb
brb approved these changes Nov 12, 2021
View reviewed changes
Copy link
Member

@brb brb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe let's add it to bpf/.gitignore.

@tklauser
Copy link
Member Author

Maybe let's add it to bpf/.gitignore.

The standalone bpf-map-migrate tool is no longer in the tree as of #16917 but the PR adding the binary was probably merged before that one. So I think we should be good without a .gitignore entry.

@tklauser tklauser added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 15, 2021
@ti-mo ti-mo merged commit 8d68d21 into cilium:master Nov 15, 2021
@tklauser tklauser deleted the rm-cilium-map-migrate-bin branch November 15, 2021 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brb brb brb approved these changes

Assignees
No one assigned
Labels
kind/cleanup This includes no functional changes. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tklauser @brb @ti-mo