Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate CiliumNode watcher #17873

Merged
merged 6 commits into from
Nov 22, 2021
Merged

Remove duplicate CiliumNode watcher #17873

merged 6 commits into from
Nov 22, 2021

Commits on Nov 22, 2021

  1. operator: merge duplicate k8s watchers 

    In certain cases the Cilium Operator could end up with two CiliumNode
k8s watchers. This commit re-writes the code in a way that a single
watcher will be used for all cases.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    6f8a4e4 View commit details
    Browse the repository at this point in the history

  2. operator: refator code from k8s_node.go to cilium_node.go 

    The code present in k8s_node was not specific to a k8s node. Thus, this
commit moved the code into a better appropriate file, cilium_node.go

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    855b271 View commit details
    Browse the repository at this point in the history

  3. operator: remove unused 'nodes-gc-interval' flag 

    This flag is no longer used in the code so we can safely remove it.

Fixes: 3aacf41 ("add capability to disable CNP NodeStatus updates")
Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    df3623a View commit details
    Browse the repository at this point in the history

  4. operator: simplify duplicated code in the event handling 

    Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    173c078 View commit details
    Browse the repository at this point in the history

  5. operator: use workqueue for event handling of CiliumNodes 

    As this code suffers a major rewrite, this commit introduces the right
way of handling Kubernetes events, with a workqueue.

Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    b7fd485 View commit details
    Browse the repository at this point in the history

  6. operator: use context of leader election for background operations 

    Signed-off-by: André Martins <andre@cilium.io>
    @aanm
    aanm committed Nov 22, 2021
    Configuration menu
    Copy the full SHA
    ab6ec99 View commit details
    Browse the repository at this point in the history