Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflows: disable no-policies/pod-to-service in clustermesh #17894

Merged
merged 2 commits into from Nov 16, 2021

Conversation

nbusseneau
Copy link
Member

The clustermesh workflow is currently disabled on cilium/cilium due to too many failures. After investigating, almost all of the failures come from the same test no-policies/pod-to-service during a curl action.

Tracking issue: cilium/cilium-cli#600

In order to re-enable the workflow, we disable the unreliable test.

The clustermesh workflow is currently disabled on `cilium/cilium` due
to too many failures. After investigating, almost all of the failures
come from the same test `no-policies/pod-to-service` during a `curl`
action.

Tracking issue: cilium/cilium-cli#600

In order to re-enable the workflow, we disable the unreliable test.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
Separating test exceptions for better readability and `git blame`
tracking.

Signed-off-by: Nicolas Busseneau <nicolas@isovalent.com>
@nbusseneau nbusseneau added area/CI Continuous Integration testing issue or flake release-note/ci This PR makes changes to the CI. labels Nov 15, 2021
@nbusseneau nbusseneau force-pushed the pr/diable-flaky-clustermesh-test branch from fb7e8d4 to 14b7fe7 Compare November 15, 2021 18:22
@nbusseneau
Copy link
Member Author

nbusseneau commented Nov 15, 2021

Link to test run of workflow changes: https://github.com/cilium/cilium/actions/runs/1463546410

EDIT: Successful!

Regular test:

✅ All 11 tests (90 actions) successful, 0 tests skipped, 5 scenarios skipped.

WireGuard test:

 ✅ All 7 tests (60 actions) successful, 4 tests skipped, 5 scenarios skipped.

Comparing with an anterior successful run https://github.com/cilium/cilium/actions/runs/1431107433 where no-policies/pod-to-service was not disabled:

Regular:

✅ All 11 tests (94 actions) successful, 0 tests skipped, 4 scenarios skipped.

WireGuard:

✅ All 7 tests (64 actions) successful, 4 tests skipped, 4 scenarios skipped.

We can see 1 scenario was additionally skipped (no-policies/pod-to-service), resulting in 4 actions less.

@nbusseneau nbusseneau marked this pull request as ready for review November 15, 2021 19:21
@nbusseneau nbusseneau requested review from a team as code owners November 15, 2021 19:21
@nbusseneau nbusseneau force-pushed the pr/diable-flaky-clustermesh-test branch from 14b7fe7 to b57ace5 Compare November 15, 2021 19:28
@nbusseneau
Copy link
Member Author

CI passed (see previous comment), removing temporary test commit.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 16, 2021
@ti-mo ti-mo merged commit d95c1eb into master Nov 16, 2021
@ti-mo ti-mo deleted the pr/diable-flaky-clustermesh-test branch November 16, 2021 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants