Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a locked function to do ipcache delete on metadata match #17909

Merged
merged 1 commit into from Nov 26, 2021

Conversation

Weil0ng
Copy link
Contributor

@Weil0ng Weil0ng commented Nov 16, 2021

Fixes potential racing condition introduced in PR #17161.

Suggested-by: Joe Stringer joe@cilium.io
Signed-off-by: Weilong Cui cuiwl@google.com

@Weil0ng Weil0ng added the release-note/misc This PR makes changes that have no direct user impact. label Nov 16, 2021
@Weil0ng Weil0ng requested a review from a team as a code owner November 16, 2021 22:33
@Weil0ng Weil0ng requested review from a team and errordeveloper November 16, 2021 22:33
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, the fix looks good to me.

I see that you have referenced my handle in the git commit message. I appreciate the acknowledgement there. Unfortunately, this also means that github will notify me any time that this commit shows up in other PRs on github, including backports. In future, you may want to consider instead adding a tag next to the signed-off-by with just the name rather than the github handle, something like:

Reported-by: Joe Stringer <joe@cilium.io> or
Suggested-by: Joe Stringer <joe@cilium.io>

@Weil0ng
Copy link
Contributor Author

Weil0ng commented Nov 16, 2021

In future, you may want to consider instead adding a tag next to the signed-off-by with just the name rather than the github handle, something like:

Reported-by: Joe Stringer <joe@cilium.io> or Suggested-by: Joe Stringer <joe@cilium.io>

Thanks for letting me know, changed commit msg, will default to this format when acknowledging folks in the future :)

@Weil0ng
Copy link
Contributor Author

Weil0ng commented Nov 16, 2021

/test

Fixes potential racing condition introduced in PR cilium#17161.

Suggested-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Weilong Cui <cuiwl@google.com>
@Weil0ng
Copy link
Contributor Author

Weil0ng commented Nov 17, 2021

/test

Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDatapathConfig Encapsulation Check iptables masquerading with random-fully

Failure Output

FAIL: Pods are not ready in time: timed out waiting for pods with filter  to be ready: 4m0s timeout expired

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-GKE so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #17881 (98.48% similarity)

@aanm aanm merged commit 3650544 into cilium:master Nov 26, 2021
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
18 tasks
@nathanjsweet nathanjsweet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants