New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a locked function to do ipcache delete on metadata match #17909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, the fix looks good to me.
I see that you have referenced my handle in the git commit message. I appreciate the acknowledgement there. Unfortunately, this also means that github will notify me any time that this commit shows up in other PRs on github, including backports. In future, you may want to consider instead adding a tag next to the signed-off-by with just the name rather than the github handle, something like:
Reported-by: Joe Stringer <joe@cilium.io>
or
Suggested-by: Joe Stringer <joe@cilium.io>
Thanks for letting me know, changed commit msg, will default to this format when acknowledging folks in the future :) |
/test |
Fixes potential racing condition introduced in PR cilium#17161. Suggested-by: Joe Stringer <joe@cilium.io> Signed-off-by: Weilong Cui <cuiwl@google.com>
/test Job 'Cilium-PR-K8s-GKE' failed and has not been observed before, so may be related to your PR: Click to show.Test Name
Failure Output
If it is a flake, comment Job 'Cilium-PR-K8s-1.21-kernel-4.19' hit: #17881 (98.48% similarity) |
Fixes potential racing condition introduced in PR #17161.
Suggested-by: Joe Stringer joe@cilium.io
Signed-off-by: Weilong Cui cuiwl@google.com