Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Remove firewall hack for OKD GSG #17924

Merged
merged 1 commit into from
Nov 18, 2021
Merged

docs: Remove firewall hack for OKD GSG #17924

merged 1 commit into from
Nov 18, 2021

Conversation

errordeveloper
Copy link
Contributor

Default tunnel and health ports had been updated in OLM repo now
(see cilium/cilium-olm@5fa5c16).

Towards: #15956

@errordeveloper
docs: Remove firewall hack for OKD GSG
69e0a26 
Default tunnel and health ports had been updated in OLM repo now
(see cilium/cilium-olm@5fa5c16).

Towards: cilium#15956

Signed-off-by: Ilya Dmitrichenko <errordeveloper@gmail.com>
@errordeveloper errordeveloper requested a review from a team as a code owner November 17, 2021 17:19
@maintainer-s-little-helper maintainer-s-little-helper bot added the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 17, 2021
@errordeveloper errordeveloper added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/minor This PR changes functionality that users may find relevant to operating Cilium. labels Nov 17, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 17, 2021
@errordeveloper errordeveloper mentioned this pull request Nov 17, 2021
Closed
joestringer
joestringer approved these changes Nov 17, 2021
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have the context here but I assume that you'll line up all of the necessary pieces for v1.11.

@errordeveloper errordeveloper added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 18, 2021
@errordeveloper
Copy link
Contributor Author

cc @michi-covalent @nathanjsweet @christarazi FYI

@gandro gandro merged commit 3d759b9 into cilium:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

Assignees
No one assigned
Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@errordeveloper @joestringer @gandro