Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

neigh: Init new neighbor for older kernel with NUD_STALE #17932

Merged
merged 1 commit into from
Nov 18, 2021
Merged

neigh: Init new neighbor for older kernel with NUD_STALE #17932

merged 1 commit into from
Nov 18, 2021

Conversation

borkmann
Copy link
Member

See commit msg.

@borkmann borkmann added the release-note/misc This PR makes changes that have no direct user impact. label Nov 18, 2021
@borkmann borkmann requested review from jrfastab and a team November 18, 2021 16:47
@borkmann borkmann added the kind/bug This is a bug in the Cilium logic. label Nov 18, 2021
@borkmann
neigh: Init new neighbor for older kernel with NUD_STALE
90f2b43 
NUD_STALE reuses the NUD_PERMANENT's prior lladdr for its stale state if the
entry existed before, and subsequently triggers a new resolution via NTF_USE
given it's none of NUD_CONNECTED, NUD_DELAY or NUD_PROBE. NUD_NONE is less
ideal for agent restarts where the agent is not aware of the already existing
entry given this would incur a tiny window where lladdr is unavailable.

Signed-off-by: Daniel Borkmann <daniel@iogearbox.net>
@borkmann
Copy link
Member Author

borkmann commented Nov 18, 2021 •
edited by maintainer-s-little-helper bot
Loading

/test

Job 'Cilium-PR-K8s-1.21-kernel-4.19' has 1 failure but they might be new flake since it also hit 1 known flake: #17881 (98.33)

jrfastab
jrfastab approved these changes Nov 18, 2021
View reviewed changes
Copy link
Contributor

@jrfastab jrfastab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, good catch.

@maintainer-s-little-helper maintainer-s-little-helper bot mentioned this pull request Nov 18, 2021
Closed
@borkmann
Copy link
Member Author

test-1.21-4.19

@maintainer-s-little-helper maintainer-s-little-helper bot added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 18, 2021
@borkmann borkmann merged commit 590e782 into master Nov 18, 2021
@borkmann borkmann deleted the pr/fix-neigh-init-state branch November 18, 2021 21:46
@guevara guevara mentioned this pull request Jul 11, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrfastab jrfastab jrfastab approved these changes

Assignees
No one assigned
Labels
kind/bug This is a bug in the Cilium logic. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@borkmann @jrfastab