Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: correct ec2 modify net iface action #17958

Merged
merged 1 commit into from Nov 26, 2021
Merged

docs: correct ec2 modify net iface action #17958

merged 1 commit into from Nov 26, 2021

Conversation

austince
Copy link
Contributor

@austince austince commented Nov 22, 2021 •
edited

The documented EC2 action does not exist.

ModifyNetworkInterface -> ModifyNetworkInterfaceAttribute

see: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ModifyNetworkInterfaceAttribute.html

Fix documented EC2 IAM action

@maintainer-s-little-helper
Copy link

Commit cdc2ca520e15ec45175cf107c99762a57cc6c0bd does not contain "Signed-off-by".

Please follow instructions provided in https://docs.cilium.io/en/stable/contributing/development/contributing_guide/#developer-s-certificate-of-origin

@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-sign-off The author needs to add signoff to their commits before merge. label Nov 22, 2021
@austince austince marked this pull request as ready for review November 22, 2021 21:51
@austince austince requested review from a team as code owners November 22, 2021 21:51
@austince austince requested review from a team, tgraf and qmonnet November 22, 2021 21:51
@joestringer joestringer added needs-backport/1.10 release-note/misc This PR makes changes that have no direct user impact. labels Nov 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 22, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Nov 22, 2021
@austince
docs: correct ec2 modify net iface action
f515c16 
`ModifyNetworkInterface` -> `ModifyNetworkInterfaceAttribute`

see: https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_ModifyNetworkInterfaceAttribute.html
Signed-off-by: austin ce <austin.cawley@gmail.com>
qmonnet
qmonnet approved these changes Nov 24, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@borkmann borkmann added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 26, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Nov 26, 2021
@aanm aanm merged commit ce45bc3 into cilium:master Nov 26, 2021
@austince austince deleted the patch-1 branch November 27, 2021 13:51
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
Merged
5 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Nov 30, 2021
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
Merged
18 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.0 Nov 30, 2021
@nathanjsweet nathanjsweet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Dec 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Dec 6, 2021
@joestringer joestringer mentioned this pull request Dec 10, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer approved these changes

@qmonnet qmonnet qmonnet approved these changes

@tgraf tgraf Awaiting requested review from tgraf tgraf was automatically assigned from cilium/aws

Assignees

@tgraf tgraf

Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.10.6
Backport done to v1.10
1.11.0
Backport done to v1.11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@austince @joestringer @qmonnet @nathanjsweet @borkmann @tgraf @aanm