Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

builder: Enable building images on arm64 #17980

Merged
merged 3 commits into from Jan 12, 2022
Merged

builder: Enable building images on arm64 #17980

merged 3 commits into from Jan 12, 2022

Conversation

jrajahalme
Copy link
Member

@jrajahalme jrajahalme commented Nov 23, 2021

Add cross-compilation packages to builder when build target is
arm64. This allows Cilium image build to succeed. Without this
builer/cilium/download-hubble.sh failed due to missing
'x86_64-linux-gnu-strip'.

Also install 'binutils-x86-64-linux-gnu' whenever installing
'binutils-aarch64-linux-gnu' to fix gops build on arm64.

Signed-off-by: Jarno Rajahalme jarno@isovalent.com

Cilium images can now be built also on arm64.

Note: This PR supersedes #17948 in order to follow through with https://docs.cilium.io/en/latest/contributing/development/images/#update-cilium-builder-and-cilium-runtime-images.

Fixes: #17056

@jrajahalme
Copy link
Member Author

@jrajahalme jrajahalme added release-note/minor This PR changes functionality that users may find relevant to operating Cilium. needs-backport/1.11 and removed dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 23, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Nov 23, 2021
@jrajahalme
Copy link
Member Author

@joestringer runtime image build is waiting for review, status shows as:

Waiting for review: release-base-images needs approval to start deploying changes.

I did not see this step being documented, unless this is covered by:

Ping one of the members of team/build to approve the build that was created by GitHub Actions here. Note that at this step cilium-builder build failure is expected since we have yet to update the runtime digest.

Maybe review == approval here?

@jrajahalme jrajahalme closed this Nov 23, 2021
@tklauser tklauser reopened this Nov 23, 2021
@tklauser tklauser temporarily deployed to release-base-images November 23, 2021 14:53 Inactive
@jrajahalme jrajahalme temporarily deployed to release-base-images November 23, 2021 15:06 Inactive
@jrajahalme jrajahalme temporarily deployed to release-base-images November 23, 2021 15:06 Inactive
@jrajahalme jrajahalme temporarily deployed to release-base-images January 12, 2022 08:05 Inactive
Signed-off-by: Jarno Rajahalme <jarno@isovalent.com>
@jrajahalme jrajahalme removed the dont-merge/needs-rebase This PR needs to be rebased because it has merge conflicts. label Jan 12, 2022
@jrajahalme jrajahalme marked this pull request as ready for review January 12, 2022 08:27
@jrajahalme
Copy link
Member Author

jrajahalme commented Jan 12, 2022

/test

Job 'Cilium-PR-K8s-1.23-kernel-net-next' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sUpdates Tests upgrade and downgrade from a Cilium stable image to master

Failure Output

FAIL: terminating containers are not deleted after timeout

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.23-kernel-net-next so I can create a new GitHub issue to track it.

@jrajahalme
Copy link
Member Author

jrajahalme commented Jan 12, 2022

/mlh new-flake Cilium-PR-K8s-1.23-kernel-net-next

👍 created #18456

@pchaigno
Copy link
Member

The GKE CI job failed with known flake #17307; k8s-1.23-kernel-net-next with known flake #18447. Reviews are in. Merging.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Jan 12, 2022
@pchaigno pchaigno merged commit db07271 into master Jan 12, 2022
@pchaigno pchaigno deleted the arm64-fixes branch January 12, 2022 15:39
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.1 Jan 14, 2022
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Needs backport from master in 1.11.1 Jan 14, 2022
@joestringer joestringer added this to Needs backport from master in 1.11.2 Jan 18, 2022
@joestringer joestringer removed this from Needs backport from master in 1.11.1 Jan 18, 2022
@kkourt kkourt added backport-pending/1.11 backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed needs-backport/1.11 labels Jan 21, 2022
@joestringer joestringer moved this from Needs backport from master to Backport done to v1.11 in 1.11.2 Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/minor This PR changes functionality that users may find relevant to operating Cilium.
Projects
No open projects
1.11.2
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

Enable Cilium images to be built from ARM instance
7 participants