contrib: Fix backport submission for own PRs #17988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GitHub, one cannot request oneself to review one's own PR. This
results in the following problem when submitting a backport PR:
$ submit-backport
Using GitHub repository joestringer/cilium (git remote: origin)
Sending PR for branch v1.10:
v1.10 backports 2021-11-23
* cilium#17788 -- Additional FQDN selector identity tracking fixes (@joestringer)
Once this PR is merged, you can update the PR labels via:
```upstream-prs
$ for pr in 17788; do contrib/backporting/set-labels.py $pr done 1.10; done
```
Sending pull request...
remote:
remote: Create a pull request for 'pr/v1.10-backport-2021-11-23' on GitHub by visiting:
remote: https://github.com/joestringer/cilium/pull/new/pr/v1.10-backport-2021-11-23
remote:
Error requesting reviewer: Unprocessable Entity (HTTP 422)
Review cannot be requested from pull request author.
Signal ERR caught!
Traceback (line function script):
58 main /home/joe/git/cilium/contrib/backporting/submit-backport
Fix this by excluding ones own username from the reviewers list.
Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
aditighag
approved these changes
Nov 29, 2021
aditighag
added
the
ready-to-merge
qmonnet
approved these changes
Nov 30, 2021
| @@ -32,15 +32,20 @@ get_remote () { | |||
| echo "$remote" | |||
| } | |||
|
|
|||
| get_user() { | |||
| gh_username=$(hub api user --flat | awk '/.login/ {print $2}') | |||
There was a problem hiding this comment.
Nit: Could be nice to cache this in a global variable, to avoid curling again on subsequent calls. But it's certainly not blocking the current PR.
|
Nominating for backport to all stable releases, as it's useful when using the backporting scripts in older branches. |
kkourt
added
backport-done/1.11
joestringer
moved this from Needs backport from master
to Backport done to v1.9
in 1.9.13
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On GitHub, one cannot request oneself to review one's own PR. This
results in the following problem when submitting a backport PR:
Fix this by excluding ones own username from the reviewers list.