Makefile: Add kind-image target #17990
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joestringer
added
the
release-note/misc
maintainer-s-little-helper
bot
added
dont-merge/needs-release-note-label
glibsm
approved these changes
Nov 24, 2021
The microk8s target previously relied on an env var declared at the top-level of the Makefile, which will conflict with an upcoming commit. Move it into a target-specific variable. This also means we can remove the redundant tagging operation. Signed-off-by: Joe Stringer <joe@cilium.io>
Add a new kind-image target, mirroring the microk8s target for building and tagging the image. To use: $ make kind <install Cilium> $ make kind-image $ kubectl -n kube-system set image daemonset/cilium cilium-agent=localhost:5000/cilium/cilium-dev:local Signed-off-by: Joe Stringer <joe@cilium.io>
joestringer
force-pushed
the
submit/make-kind-image
branch
from
5820e17
to
ed6f8fd
Compare
joestringer
added
the
ready-to-merge
|
Marking for backport to make v1.11 debugging easier in future. |
tklauser
added
backport-done/1.11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new kind-image target, mirroring the microk8s target for building
and tagging the image.
To use: