Update kind documentation #18007
Merged
Update kind documentation #18007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The clustermesh guide has installation instructions using cilium CLI so let's use that. Signed-off-by: Aditi Ghag <aditi@cilium.io>
17 tasks
qmonnet
reviewed
Nov 25, 2021
There was a problem hiding this comment.
The “Deploy Cilium” section that you remove seemed to do things slightly differently than the default installation (see below)? But if you double-checked and this is correct, then I'm good.
I'm sorry, I'm not sure either regarding your question above. @dctrwatson do you remember?
|
I merged the change. If you get an answer to your question, we can clarify the note in a follow-up. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Question :
Which NodePort service is it referring to here? I suppose it might referring to the
--service-typeparameter we need to mention while enabling clustermesh using CLI, but it's not 100% clear.