New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add registry (quay.io/) for pre-loading images for kind #18017
Conversation
Hi and thanks! |
Apologies, I had missed your explanation in the second part of your PR description. Makes sense, in that case. |
9a9abfe
to
86efd57
Compare
done |
86efd57
to
459ce27
Compare
One last thing, could you fix your |
in doc, it recommends docker pull image, but the command is : docker pull cilium/cilium:|IMAGE_TAG| this will download from docker.io However, in operator, it loads images from quay.io we should keep them the same, otherwise, we download for nothing. Signed-off-by: adamzhoul <adamzhoul186@gmail.com>
459ce27
to
1d21df2
Compare
sorry for the trouble. |
No need to apologies, thanks again for your contribution! |
@adamzhoul thanks for the fix, for the authors file is it OK to refer to you as |
Please ensure your pull request adheres to the following guidelines:
description and a
Fixes: #XXX
line if the commit addresses a particularGitHub issue.
in doc, it recommends docker pull image, but the command is :
this will download from docker.io
However, in operator, it loads images from quay.io
we should keep them the same, otherwise, we download for nothing.
Signed-off-by: adamzhoul adamzhoul186@gmail.com