doc: getting started minor fixes #18024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kaworu
added
area/documentation
qmonnet
reviewed
Nov 26, 2021
qmonnet
approved these changes
Nov 26, 2021
michi-covalent
approved these changes
Nov 29, 2021
|
Can you please fix the typos in your commit descriptions reported by checkpatch? |
kaworu
force-pushed
the
pr/kaworu/v1.11-prep-doc-changes
branch
from
3a26b69
to
a5e1377
Compare
|
@qmonnet @michi-covalent marking this PR as |
kaworu
added
the
ready-to-merge
aanm
requested changes
Dec 3, 2021
aanm
removed
the
ready-to-merge
nathanjsweet
added
the
dont-merge/needs-rebase
kaworu
force-pushed
the
pr/kaworu/v1.11-prep-doc-changes
branch
2 times, most recently
from
6cff5bd
to
a698b32
Compare
|
@kaworu What's the status on this? Looks ready to merge? |
kaworu
force-pushed
the
pr/kaworu/v1.11-prep-doc-changes
branch
from
a698b32
to
ff54e09
Compare
Before this patch, the EKS requirements documentation would also include creating a new cluster with eksctl. Because of that, the Quick Installation guide would have the cluster creation instructions duplicated, and the Helm installation guide would include the cluster creation (only for EKS). Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
To bring it in line with other provider documentation. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
kaworu
force-pushed
the
pr/kaworu/v1.11-prep-doc-changes
branch
from
ff54e09
to
0aeff90
Compare
When copying from a shell-session code block, hash (#) characters are omitted. In this case, the hash characters are used to comment lines in a here doc YAML file and must be included. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Before this patch the document was inconsistent in naming managed Kubernetes provider names. Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
Yes I think so, marking as ready-to-merge since it this PR doesn't need a CI run (doc only changes). |
kaworu
added
the
ready-to-merge
kkourt
added
backport-done/1.11
joestringer
moved this from Needs backport from master
to Backport done to v1.10
in 1.10.8
joestringer
moved this from Needs backport from master
to Backport done to v1.11
in 1.11.2
This was referenced Feb 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See patches.