Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: use ipv4NativeRoutingCIDR instead of nativeRoutingCIDR #18026

Merged
merged 1 commit into from Nov 29, 2021
Merged

doc: use ipv4NativeRoutingCIDR instead of nativeRoutingCIDR #18026

merged 1 commit into from Nov 29, 2021

Conversation

kaworu
Copy link
Member

@kaworu kaworu commented Nov 26, 2021

As the latter has been deprecated in favor of the former.

@kaworu kaworu added area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. release-note/misc This PR makes changes that have no direct user impact. labels Nov 26, 2021
@kaworu kaworu requested a review from jibi November 26, 2021 16:03
@kaworu kaworu self-assigned this Nov 26, 2021
@kaworu kaworu requested a review from a team as a code owner November 26, 2021 16:03
jibi
jibi approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jibi jibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍
While at it could you also update the k8s-install-openshift-okd.rst and k8s-install-helm.rst docs please (as they are still referencing nativeRoutingCIDR)?

@kaworu
doc: use ipv4NativeRoutingCIDR instead of nativeRoutingCIDR
f50c76e 
As the latter has been deprecated in favor of the former.

Signed-off-by: Alexandre Perrin <alex@kaworu.ch>
@kaworu kaworu force-pushed the pr/kaworu/ipsec-documentation-fix branch from 99b3e90 to f50c76e Compare November 29, 2021 11:15
@kaworu kaworu changed the title doc/ipsec: use ipv4NativeRoutingCIDR instead of nativeRoutingCIDR doc: use ipv4NativeRoutingCIDR instead of nativeRoutingCIDR Nov 29, 2021
@kaworu
Copy link
Member Author

kaworu commented Nov 29, 2021

@jibi thanks, it's done please take another look

jibi
jibi approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@jibi jibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@kaworu kaworu added the backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. label Nov 29, 2021
qmonnet
qmonnet approved these changes Nov 29, 2021
View reviewed changes
Copy link
Member

@qmonnet qmonnet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!
I'll assume you meant to label needs-backport/1.11.

@qmonnet qmonnet added needs-backport/1.11 and removed backport/1.11 This PR represents a backport for Cilium 1.11.x of a PR that was merged to main. labels Nov 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Nov 29, 2021
@qmonnet qmonnet merged commit e03bfff into cilium:master Nov 29, 2021
joestringer
joestringer reviewed Nov 29, 2021
View reviewed changes
Copy link
Member

@joestringer joestringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kaworu please add a note to the upgrade guide about this renaming.

@kaworu kaworu deleted the pr/kaworu/ipsec-documentation-fix branch November 30, 2021 08:41
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
Merged
18 tasks
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.11.0 Nov 30, 2021
@kaworu kaworu mentioned this pull request Dec 2, 2021
Merged
@kaworu
Copy link
Member Author

kaworu commented Dec 2, 2021

@joestringer sure thing, see #18095

@nathanjsweet nathanjsweet added the backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. label Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.11 in 1.11.0 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joestringer joestringer joestringer left review comments

@jibi jibi jibi approved these changes

@qmonnet qmonnet qmonnet approved these changes

Assignees

@kaworu kaworu

@joestringer joestringer

Labels
area/documentation Impacts the documentation, including textual changes, sphinx, or other doc generation code. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.0
Backport done to v1.11
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@kaworu @jibi @joestringer @qmonnet @nathanjsweet