bpf: update dsr flag properly

[Inode1]

I reproduced this issue and after this patch new tcp sessions with dsr flag update the already created entries in the conntrack table.

Fix TCP connectivity issues in the DSR mode when conntrack entries with missing DSR flag are reused.

Fixes: #17759

[pchaigno]

/test

Job 'Cilium-PR-K8s-1.22-kernel-4.19' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sServicesTest Checks service across nodes Tests NodePort BPF Tests with direct routing Tests NodePort

Failure Output

FAIL: Request from k8s1 to service http://[fd04::11]:32538 failed

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.22-kernel-4.19 so I can create a new GitHub issue to track it.

Job 'Cilium-PR-K8s-1.21-kernel-5.4' hit: #17353 (89.67% similarity)

[Inode1]

/test

[Inode1]

test-1.22-4.19

[Inode1]

/test-1.22-4.19

[Inode1]

@pchaigno Hello, could you recheck this commit please. IMO, based on the logs of failed tests, I don’t think my PR was the cause of these problems.

[brb]

Thanks for the PR!

A few comments. Also, could you improve the commit msg. In particular, it should describe the problem your commit tries to solve, and then briefly discuss the solution.

I've checked the CI failures - all of them are flakes and unrelated to your changes.

[Inode1]

@brb, Hello. Here you are, I update the commit msg and describe the problem and the solution.

[brb]

@Inode1 Thanks for the updated commit msg.

[brb]

/test

Job 'Cilium-PR-K8s-1.21-kernel-5.4' failed and has not been observed before, so may be related to your PR:

Click to show.

Test Name

K8sDatapathConfig AutoDirectNodeRoutes Check connectivity with sockops and direct routing

Failure Output

FAIL: Error creating resource /home/jenkins/workspace/Cilium-PR-K8s-1.21-kernel-5.4/src/github.com/cilium/cilium/test/k8sT/manifests/l3-policy-demo.yaml: Cannot retrieve cilium pod cilium-r2hv9 policy revision: cannot get revision from json output 'Defaulted container "cilium-agent" out of: cilium-agent, mount-cgroup (init), clean-cilium-state (init)

If it is a flake, comment /mlh new-flake Cilium-PR-K8s-1.21-kernel-5.4 so I can create a new GitHub issue to track it.

[brb]

/test

[brb]

test-gke

Job 'Cilium-PR-K8s-GKE' hit: #18218 (92.43% similarity)

[Inode1]

@brb, Hello. There are several failed tests, is it somehow connected with my PR? Do you need any help from me?

[brb]

The test failures are unrelated (#18218). Marking as ready to merge.

[nbusseneau]

@Inode1 Thanks for your contribution :) Merging the PR.

[Inode1]

Thanks, good news.