Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpf: Add WireGuard to complexity and compile tests #18048

Merged
merged 1 commit into from Nov 30, 2021

Conversation

pchaigno
Copy link
Member

ENABLE_WIREGUARD was missing from the compile tests in bpf/Makefile and from the complexity tests in bpf/complexity-tests. We could therefore have missed new complexity issues or compilation errors occurring only when WireGuard is enabled.

Fixes: 8930beb ("daemon: Configure Wireguard for local node")

ENABLE_WIREGUARD was missing from the compile tests in bpf/Makefile and
from the complexity tests in bpf/complexity-tests. We could therefore
have missed new complexity issues or compilation errors occurring only
when WireGuard is enabled.

Fixes: 8930beb ("daemon: Configure Wireguard for local node")
Reported-by: Joe Stringer <joe@cilium.io>
Signed-off-by: Paul Chaignon <paul@cilium.io>
@pchaigno pchaigno added area/CI Continuous Integration testing issue or flake sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages. area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. kind/complexity-issue Relates to BPF complexity or program size issues labels Nov 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. labels Nov 29, 2021
@pchaigno
Copy link
Member Author

pchaigno commented Nov 29, 2021

Only the net-next build is affected, via K8sVerifier:

/test-netnext

@pchaigno pchaigno marked this pull request as ready for review November 29, 2021 18:24
@pchaigno pchaigno requested a review from a team November 29, 2021 18:24
@pchaigno pchaigno requested a review from a team as a code owner November 29, 2021 18:24
@pchaigno pchaigno added the release-note/ci This PR makes changes to the CI. label Nov 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot removed the dont-merge/needs-release-note-label The author needs to describe the release impact of these changes. label Nov 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Nov 29, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.10.6 Nov 29, 2021
@pchaigno pchaigno removed the request for review from ti-mo November 30, 2021 09:08
@pchaigno
Copy link
Member Author

Net-next test is passing and team review requests are covered. Marking ready to merge.

@pchaigno pchaigno added the ready-to-merge This PR has passed all tests and received consensus from code owners to merge. label Nov 30, 2021
@qmonnet qmonnet merged commit 04bf74c into cilium:master Nov 30, 2021
@pchaigno pchaigno deleted the test-complexity-wireguard branch November 30, 2021 16:54
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
18 tasks
@nathanjsweet nathanjsweet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.11 in 1.11.0 Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.11 in 1.11.0 Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport pending to v1.10 in 1.10.6 Dec 6, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Backport pending to v1.10 to Backport done to v1.10 in 1.10.6 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/CI Continuous Integration testing issue or flake area/encryption Impacts encryption support such as IPSec, WireGuard, or kTLS. backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. kind/complexity-issue Relates to BPF complexity or program size issues ready-to-merge This PR has passed all tests and received consensus from code owners to merge. release-note/ci This PR makes changes to the CI. sig/datapath Impacts bpf/ or low-level forwarding details, including map management and monitor messages.
Projects
No open projects
1.10.6
Backport done to v1.10
1.11.0
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

7 participants