Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github: add workflow to build beta images #18052

Merged
merged 1 commit into from Nov 30, 2021

Conversation

aanm
Copy link
Member

@aanm aanm commented Nov 30, 2021

With this new workflow, developers will be able to release beta features
that are created on top of an existing release.

The workflow to create a new beta image is as follow:

  1. Push a branch into Cilium's repository with the name:
    feature/<stable-branch>/<feature-name> where <stable-branch>
    represents the branch where the feature is based on and
    <feature-name> represents the name of the feature being released.
  2. Trigger the workflow by going into [1], use the workflow from
    feature/<stable-branch>/<feature-name> branch and write an image
    tag name.
    The tag name should be in the format vX.Y.Z-<feature-name> where
    vX.Y.Z is the version on which the branch is built on, and
    <feature-name> the name of the feature.
  3. Ping one of the maintainers or anyone from the cilium-build team to
    approve the build and release process of this feature.

[1] https://github.com/cilium/cilium/actions/workflows/build-images-beta.yaml

Signed-off-by: André Martins andre@cilium.io

@aanm aanm added release-note/misc This PR makes changes that have no direct user impact. needs-backport/1.11 labels Nov 30, 2021
@aanm aanm requested review from a team as code owners November 30, 2021 04:44
@aanm aanm requested a review from pchaigno November 30, 2021 04:44
@maintainer-s-little-helper maintainer-s-little-helper bot added this to Needs backport from master in 1.11.0 Nov 30, 2021
@aanm aanm requested a review from jrajahalme November 30, 2021 04:44
Copy link
Member

@jrajahalme jrajahalme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK, but need to test this once this is merged. Small question for clarification below :)

.github/workflows/build-images-beta.yaml Show resolved Hide resolved
With this new workflow, developers will be able to release beta features
that are created on top of an existing release.

The workflow to create a new beta image is as follow:

1. Push a branch into Cilium's repository with the name:
   `feature/<stable-branch>/<feature-name>` where `<stable-branch>`
   represents the branch where the feature is based on and
   `<feature-name>` represents the name of the feature being released.
2. Trigger the workflow by going into [1], use the workflow from
   `feature/<stable-branch>/<feature-name>` branch and write an image
   tag name.
   The tag name should be in the format `vX.Y.Z-<feature-name>` where
   `vX.Y.Z` is the version on which the branch is built on, and
   `<feature-name>` the name of the feature.
3. Ping one of the maintainers or anyone from the cilium-build team to
   approve the build and release process of this feature.

[1] https://github.com/cilium/cilium/actions/workflows/build-images-beta.yaml

Signed-off-by: André Martins <andre@cilium.io>
@aanm aanm merged commit 420028f into cilium:master Nov 30, 2021
@aanm aanm deleted the pr/add-beta-repositories branch November 30, 2021 22:43
@qmonnet qmonnet mentioned this pull request Nov 30, 2021
18 tasks
@nathanjsweet nathanjsweet added backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. and removed backport-pending/1.11 labels Dec 2, 2021
@maintainer-s-little-helper maintainer-s-little-helper bot moved this from Needs backport from master to Backport done to v1.11 in 1.11.0 Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-done/1.11 The backport for Cilium 1.11.x for this PR is done. release-note/misc This PR makes changes that have no direct user impact.
Projects
No open projects
1.11.0
Backport done to v1.11
Development

Successfully merging this pull request may close these issues.

None yet

5 participants